Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rollout not modify the VirtualService whit setHeaderRoute step #2797

Merged
merged 5 commits into from
Jul 24, 2023

Conversation

huoyinghao
Copy link
Contributor

@huoyinghao huoyinghao commented May 19, 2023

closes: #2780

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

remove the generation check for set header route,
When using Workload Ref to associate resources, we modify the mirror version of the resources, and the generation of rollouts will not be updated

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2023

Go Published Test Results

2 032 tests   2 032 ✔️  2m 40s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit 29cf48a.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (20e00e4) 81.68% compared to head (29cf48a) 81.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2797      +/-   ##
==========================================
+ Coverage   81.68%   81.71%   +0.02%     
==========================================
  Files         133      133              
  Lines       20309    20324      +15     
==========================================
+ Hits        16589    16607      +18     
+ Misses       2862     2860       -2     
+ Partials      858      857       -1     
Impacted Files Coverage Δ
rollout/trafficrouting.go 73.92% <100.00%> (+0.09%) ⬆️
utils/annotations/annotations.go 97.53% <100.00%> (+0.23%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2023

E2E Tests Published Test Results

    4 files      4 suites   3h 39m 36s ⏱️
102 tests   89 ✔️   6 💤   7
418 runs  384 ✔️ 24 💤 10

For more details on these failures, see this check.

Results for commit 29cf48a.

♻️ This comment has been updated with latest results.

@huoyinghao huoyinghao force-pushed the remove-generation branch from 34ca0f1 to dfc2625 Compare May 19, 2023 09:56
@huoyinghao huoyinghao changed the title remove generation whil setHeaderRoute and setMirrorRoute fix: rollout not modify the VirtualService whit setHeaderRoute step May 19, 2023
@huoyinghao huoyinghao force-pushed the remove-generation branch from 59d135c to a6f9d13 Compare May 19, 2023 10:07
@huoyinghao huoyinghao force-pushed the remove-generation branch from a6f9d13 to c11c185 Compare June 5, 2023 08:18
@sonarcloud
Copy link

sonarcloud bot commented Jun 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
23.3% 23.3% Duplication

@zachaller zachaller added this to the v1.6 milestone Jun 13, 2023
@zachaller zachaller force-pushed the remove-generation branch from c11c185 to 60d5f18 Compare July 20, 2023 16:25
Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
32.1% 32.1% Duplication

@zachaller zachaller merged commit 9365aca into argoproj:master Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SetHeaderRoute not change VirtualService
2 participants