fix: properly wrap Datadog API v2 request body (#2771) #2775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Eftimie <[email protected]>
alexef
changed the title
alexef
changed the title
alexef
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2775 +/- ##
=======================================
Coverage 81.64% 81.64%
=======================================
Files 133 133
Lines 20177 20178 +1
=======================================
+ Hits 16474 16475 +1
Misses 2849 2849
Partials 854 854
☔ View full report in Codecov by Sentry. |
Signed-off-by: Alex Eftimie <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
zachaller
approved these changes
May 14, 2023
zachaller
pushed a commit
that referenced
this pull request
May 24, 2023
* Datadog: properly wrap request body Signed-off-by: Alex Eftimie <[email protected]> * Use milliseconds in v2 calls to datadog Signed-off-by: Alex Eftimie <[email protected]> --------- Signed-off-by: Alex Eftimie <[email protected]>
zachaller
added
the
cherry-pick-completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is more inline with the docs at: https://docs.datadoghq.com/api/latest/metrics/?code-lang=curl#query-timeseries-data-across-multiple-products
fixes: #2771
Checklist:
"fix(controller): Updates such and such. Fixes #1234".