chore: Add tests for pause functionality in rollout package #2772

zhaque44 · 2023-05-11T04:35:18Z

The TestHasAddPause checks the behavior of the HasAddPause() function in the pauseContext struct. It creates a pauseContext instance with an empty v1alpha1.RolloutStatus and an empty list of pause conditions. It sets one addPauseReason with the value v1alpha1.PauseReasonCanaryPauseStep with an empty list for removePauseReasons. The test then calls the function on the pauseContext and asserts that the result is true.
The test TestHasAddPauseNoReasons is basically the unhappy path for the HasAddPause() function. It creates a pauseContext instance with an empty v1alpha1.RolloutStatus and an empty list of pause conditions. It sets both the addPauseReasons and removePauseReasons lists as empty. The test then calls the function and asserts that the result is false.
The test TestCalculatePauseStatus checks the behavior of the CalculatePauseStatus() function in the pauseContext struct. It creates a pauseContext instance with an empty v1alpha1.RolloutStatus and an empty list of pause conditions. It sets one addPauseReason with the value v1alpha1.PauseReasonCanaryPauseStep and keeps an empty list for removePauseReasons. The test creates an empty newStatus variable of type v1alpha1.RolloutStatus and calls the CalculatePauseStatus(newStatus) method.
The test TestCalculatePauseStatusRemovePause is the unhappy path of the CalculatePauseStatus() function with assertions.
The TestCompletedBlueGreenPause test checks the behavior of the CompletedBlueGreenPause() function for a Blue-Green deployment strategy. It creates a pauseContext instance with a v1alpha1.Rollout having a Blue-Green strategy, ControllerPause is set to true, with one pause condition v1alpha1.PauseReasonBlueGreenPause & ScaleUpPreviewCheckPoint is set to true. The test then calls the function and asserts that the result is true.
The test TestCompletedBlueGreenPauseAutoPromotionDisabled is the unhappy path of the CompletedBlueGreenPause() function with assertions.

Checklist:

Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
I've signed my commits with DCO
I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
My builds are green. Try syncing with master if they are not.
My organization is added to USERS.md.

github-actions · 2023-05-11T04:45:28Z

Go Published Test Results

1 960 tests 1 960 ✔️ 2m 35s ⏱️
  118 suites       0 💤
      1 files       0 ❌

Results for commit 60f9121.

♻️ This comment has been updated with latest results.

codecov · 2023-05-11T04:48:09Z

Codecov Report

Patch and project coverage have no change.

Comparison is base (13b988e) 81.64% compared to head (60f9121) 81.64%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2772   +/-   ##
=======================================
  Coverage   81.64%   81.64%           
=======================================
  Files         133      133           
  Lines       20178    20178           
=======================================
  Hits        16475    16475           
  Misses       2849     2849           
  Partials      854      854

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.