Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat NaN as inconclusive #275

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Treat NaN as inconclusive #275

merged 1 commit into from
Nov 7, 2019

Conversation

dthomson25
Copy link
Member

Closes #180

@codecov
Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #275 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #275      +/-   ##
=========================================
+ Coverage   83.65%   83.7%   +0.04%     
=========================================
  Files          63      63              
  Lines        5561    5553       -8     
=========================================
- Hits         4652    4648       -4     
+ Misses        667     665       -2     
+ Partials      242     240       -2
Impacted Files Coverage Δ
metricproviders/prometheus/prometheus.go 100% <100%> (ø) ⬆️
utils/template/template.go
utils/query/query.go 100% <0%> (ø)
metricproviders/job/job.go 91.52% <0%> (+2.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21f6e56...8759706. Read the comment docs.

@dthomson25 dthomson25 merged commit c7fbcb3 into master Nov 7, 2019
@dthomson25 dthomson25 deleted the nan-inconclusive branch November 7, 2019 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus metric to treat NaN as Inconclusive
2 participants