Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify experiment replicaset names. Surface experiment images to CLI #274

Merged
merged 2 commits into from
Nov 7, 2019

Conversation

jessesuen
Copy link
Member

image

  1. Removes the pod template hash from replicasets created from experiments
  2. Surface any running images of experiments to the CLI

@codecov
Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #274 into master will increase coverage by 0.19%.
The diff coverage is 89.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
+ Coverage   83.68%   83.88%   +0.19%     
==========================================
  Files          63       63              
  Lines        5548     5553       +5     
==========================================
+ Hits         4643     4658      +15     
+ Misses        665      655      -10     
  Partials      240      240
Impacted Files Coverage Δ
pkg/kubectl-argo-rollouts/info/info.go 100% <100%> (ø) ⬆️
pkg/kubectl-argo-rollouts/info/replicaset_info.go 79.41% <100%> (+0.3%) ⬆️
experiments/replicaset.go 81.45% <100%> (-0.15%) ⬇️
pkg/kubectl-argo-rollouts/info/experiment_info.go 67.92% <66.66%> (+4.15%) ⬆️
pkg/kubectl-argo-rollouts/info/rollout_info.go 85.62% <90.24%> (+3.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ad38b7...25d8306. Read the comment docs.

@jessesuen jessesuen force-pushed the simplify-exp-templates branch from ed9432d to 1c0d54d Compare November 7, 2019 10:34
Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessesuen jessesuen merged commit 6b98508 into argoproj:master Nov 7, 2019
@jessesuen jessesuen deleted the simplify-exp-templates branch November 7, 2019 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants