-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: retryable http client for datadog metric provider #2580
base: master
Are you sure you want to change the base?
feat: retryable http client for datadog metric provider #2580
Conversation
Signed-off-by: kaldorn <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2580 +/- ##
==========================================
+ Coverage 81.52% 81.55% +0.02%
==========================================
Files 131 131
Lines 19587 19596 +9
==========================================
+ Hits 15969 15981 +12
+ Misses 2797 2795 -2
+ Partials 821 820 -1 ☔ View full report in Codecov by Sentry. |
@kaldorn can I get you to run |
Signed-off-by: kaldorn <[email protected]>
Signed-off-by: kaldorn <[email protected]>
@zachaller done, i apologize for the delay. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@kaldorn I merged the pr to add datadog v2 to master. I am ok with also having retries if you want to add it will require a rebase and addition to both v1 and v2, if you do not and v2 is enough for your rate limiting/errors issues etc we can close this. |
This PR is stale because it has been open 90 days with no activity. |
Adds a retryable http.client that automatically handles 429 rate limit responses with exponential backoff.
Not 100% sure this is the best approach for this, open to suggestions.
related to: #2549
closes: #2578
Signed-off-by: kaldorn [[email protected]]
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.