feat: use retryable http client for datadog metric provider #2579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 9, 2023 10:53
Codecov ReportBase: 81.60% // Head: 81.62% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2579 +/- ##
==========================================
+ Coverage 81.60% 81.62% +0.02%
==========================================
Files 130 130
Lines 19483 19488 +5
==========================================
+ Hits 15900 15908 +8
+ Misses 2766 2764 -2
+ Partials 817 816 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
added 2 commits
February 9, 2023 14:51
Signed-off-by: kaldorn <[email protected]>
…der' of github.com:getoutreach/argoproj-argo-rollouts into feat-use-retryable-http-client-for-datadog-metric-provider
|
Kudos, SonarCloud Quality Gate passed!
|
* Add name attribute to ServicePort Signed-off-by: Daniel Del Rio <[email protected]> * Format with gofmt Signed-off-by: Daniel Del Rio <[email protected]> * Update experiment test by adding port name Signed-off-by: Daniel Del Rio <[email protected]> * Include port name only when given Signed-off-by: Daniel Del Rio <[email protected]> * Implement separate e2e tests for single unnamed port and two named ports Signed-off-by: Daniel Del Rio <[email protected]> * Remove port name in experiment_test.go Signed-off-by: Daniel Del Rio <[email protected]> * Replace Sleep in new multiport service experiment Signed-off-by: Daniel Del Rio <[email protected]> --------- Signed-off-by: Daniel Del Rio <[email protected]> Signed-off-by: kaldorn <[email protected]>
Signed-off-by: Nate Kaldor [[email protected]] Signed-off-by: kaldorn <[email protected]>
Signed-off-by: kaldorn <[email protected]>
…der' of github.com:getoutreach/argoproj-argo-rollouts into feat-use-retryable-http-client-for-datadog-metric-provider
kaldorn
deleted the
feat-use-retryable-http-client-for-datadog-metric-provider
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a retryable http.client that automatically handles 429 rate limit responses with exponential backoff.
related to: #2549
closes: #2578
Signed-off-by: kaldorn [[email protected]]
Checklist:
"fix(controller): Updates such and such. Fixes #1234".