Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove namespaced crds #2516

Merged
merged 3 commits into from
Jan 15, 2023
Merged

chore: Remove namespaced crds #2516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1c4ba0
chore: Remove CRDs from namespaced installation
sfenman Jan 13, 2023
88dcf30
docs: Add README for manifests
sfenman Jan 13, 2023
9ebd6b4
docs: Update installation methods
sfenman Jan 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions docs/installation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## Controller Installation

Two types of installation:

* [install.yaml](https://github.com/argoproj/argo-rollouts/blob/master/manifests/install.yaml) - Standard installation method.
```bash
kubectl create namespace argo-rollouts
kubectl apply -n argo-rollouts -f https://github.com/argoproj/argo-rollouts/releases/latest/download/install.yaml
Expand All @@ -10,25 +13,36 @@ kubectl apply -n argo-rollouts -f https://github.com/argoproj/argo-rollouts/rele
This will create a new namespace, `argo-rollouts`, where Argo Rollouts controller will run.

!!! tip
If you are using another namspace name, please update `install.yaml` clusterrolebinding's serviceaccount namespace name.
If you are using another namespace name, please update `install.yaml` clusterrolebinding's serviceaccount namespace name.

!!! tip
When installing Argo Rollouts on Kubernetes v1.14 or lower, the CRD manifests must be kubectl applied with the --validate=false option. This is caused by use of new CRD fields introduced in v1.15, which are rejected by default in lower API servers.


!!! tip
!!! tip
On GKE, you will need grant your account the ability to create new cluster roles:

```shell
kubectl create clusterrolebinding YOURNAME-cluster-admin-binding --clusterrole=cluster-admin [email protected]
```

* [namespace-install.yaml](https://github.com/argoproj/argo-rollouts/blob/master/manifests/namespace-install.yaml) - Installation of Argo Rollouts which requires
only namespace level privileges. An example usage of this installation method would be to run several Argo Rollouts controller instances in different namespaces
on the same cluster.

> Note: Argo Rollouts CRDs are not included into [namespace-install.yaml](https://github.com/argoproj/argo-rollouts/blob/master/manifests/namespace-install.yaml).
> and have to be installed separately. The CRD manifests are located in [manifests/crds](https://github.com/argoproj/argo-rollouts/blob/master/manifests/crds) directory.
> Use the following command to install them:
> ```bash
> kubectl apply -k https://github.com/argoproj/argo-rollouts/manifests/crds\?ref\=stable
> ```

You can find released container images of the controller at [Quay.io](https://quay.io/repository/argoproj/argo-rollouts?tab=tags). There are also old releases
at Dockerhub, but since the introduction of rate limiting, the Argo project has moved to Quay.

## Kubectl Plugin Installation

The kubectl plugin is optional, but is convenient for managing and visualizing rollouts from the
The kubectl plugin is optional, but is convenient for managing and visualizing rollouts from the
command line.

### Brew
Expand All @@ -44,7 +58,7 @@ brew install argoproj/tap/kubectl-argo-rollouts
curl -LO https://github.com/argoproj/argo-rollouts/releases/latest/download/kubectl-argo-rollouts-darwin-amd64
```

!!! tip ""
!!! tip ""
For Linux dist, replace `darwin` with `linux`

1. Make the kubectl-argo-rollouts binary executable.
Expand Down Expand Up @@ -106,7 +120,7 @@ To upgrade Argo Rollouts:
2. Delete the previous version of the controller and apply/install the new one
3. When a new Rollout takes place the new controller will be activated.

If deployments are happening while you upgrade the controller, then you shouldn't
If deployments are happening while you upgrade the controller, then you shouldn't
have any downtime. Current Rollouts will be paused and as soon as the new controller becomes
active it will resume all in-flight deployments.

13 changes: 13 additions & 0 deletions manifests/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Argo Rollouts Installation Manifests

* [install.yaml](install.yaml) - Standard installation method. This will create a new namespace, `argo-rollouts`,
where Argo Rollouts controller will run.

* [namespace-install.yaml](namespace-install.yaml) - Installation which requires only namespace level privileges.

> Note: Argo Rollouts CRDs are not included into [namespace-install.yaml](namespace-install.yaml).
> and have to be installed separately. The CRD manifests are located in [manifests/crds](./crds) directory.
> Use the following command to install them:
> ```bash
> kubectl apply -k https://github.com/argoproj/argo-rollouts/manifests/crds\?ref\=stable
> ```
Loading