build: manually run auto changelog and fix workflow #2494
Conversation
Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
Codecov ReportBase: 81.67% // Head: 81.68% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2494 +/- ##
=======================================
Coverage 81.67% 81.68%
=======================================
Files 126 126
Lines 19124 19132 +8
=======================================
+ Hits 15620 15628 +8
Misses 2710 2710
Partials 794 794
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
zachaller
changed the title
CHANGELOG-AUTO.md
Outdated
| @@ -0,0 +1,203 @@ | |||
|
|
|||
There was a problem hiding this comment.
We already have a CHANGELOG.md in root folder. I don't think it is a good idea to have 2 changelog files. Maybe I am misunderstanding the strategy behind this new file.
There was a problem hiding this comment.
So the old CHANGELOG was a manually created file. That dose not really make sense to maintain I had wanted to see how well the auto generated changelog tooling worked for a while before removing and/or deprecating the old CHANGELOG.md. If you think we should just do that now we can. One issue though is that the auto generated tooling replaces the whole file each time, so if we wanted to keep the old one we would need to rename it something like CHANGELOG-v0.1.0-v1.1.0.md or something like that and then just have the new auto generated stuff go into CHANGELOG.md
There was a problem hiding this comment.
I will also point out slightly this first run for 1.4 is also not 100% perfect because sematic pr titles where note enabled for all of it so there is a few wrong headings etc but going forward it should be reallly good.
There was a problem hiding this comment.
Renaming the old one makes sense to me. I agree that the new file should be just CHANGELOG.md.
There was a problem hiding this comment.
Sounds good let me update
Signed-off-by: zachaller <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
* fix: manually run auto changelog and fix workflow Signed-off-by: zachaller <[email protected]> * fix: add workflow changes Signed-off-by: zachaller <[email protected]> * change name on old CHANGELOG and make autogen primary Signed-off-by: zachaller <[email protected]> Signed-off-by: zachaller <[email protected]>
* fix: manually run auto changelog and fix workflow Signed-off-by: zachaller <[email protected]> * fix: add workflow changes Signed-off-by: zachaller <[email protected]> * change name on old CHANGELOG and make autogen primary Signed-off-by: zachaller <[email protected]> Signed-off-by: zachaller <[email protected]> Signed-off-by: Travis Perdue <[email protected]>
* fix: manually run auto changelog and fix workflow Signed-off-by: zachaller <[email protected]> * fix: add workflow changes Signed-off-by: zachaller <[email protected]> * change name on old CHANGELOG and make autogen primary Signed-off-by: zachaller <[email protected]> Signed-off-by: zachaller <[email protected]> Signed-off-by: Travis Perdue <[email protected]>
Fixes the workflow to use the right binary os and do a manually run for 1.4.0-rc1
Signed-off-by: zachaller [email protected]