-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix checksum generation #2481
Conversation
Signed-off-by: Justin Marquis <[email protected]>
Signed-off-by: Justin Marquis <[email protected]>
Codecov ReportBase: 81.67% // Head: 81.67% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2481 +/- ##
=======================================
Coverage 81.67% 81.67%
=======================================
Files 126 126
Lines 19124 19124
=======================================
Hits 15620 15620
Misses 2710 2710
Partials 794 794 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: zachaller <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
Just an fyi, I removed the public cosing key, when I talked to Jesse about this and I think it makes sense as well we did not want to really publish a pub key outside of the release. The reason for this is if we ever need to rotate the private key if users are used to having to pull public keys from the release assets only it makes it really easy to rotate without having to have a notice of the leak and breaking newer releases from being checked if they are always just pulling the pub key from the release they will always have the correct key even if we switch. Do you see any issue with that? |
* chore: fix checksum generation and sign sbom Signed-off-by: Justin Marquis <[email protected]> * cosign public key for public record Signed-off-by: Justin Marquis <[email protected]> * remove pub key for cosign Signed-off-by: zachaller <[email protected]> Signed-off-by: Justin Marquis <[email protected]> Signed-off-by: zachaller <[email protected]> Co-authored-by: zachaller <[email protected]>
* chore: fix checksum generation and sign sbom Signed-off-by: Justin Marquis <[email protected]> * cosign public key for public record Signed-off-by: Justin Marquis <[email protected]> * remove pub key for cosign Signed-off-by: zachaller <[email protected]> Signed-off-by: Justin Marquis <[email protected]> Signed-off-by: zachaller <[email protected]> Co-authored-by: zachaller <[email protected]> Signed-off-by: Travis Perdue <[email protected]>
* chore: fix checksum generation and sign sbom Signed-off-by: Justin Marquis <[email protected]> * cosign public key for public record Signed-off-by: Justin Marquis <[email protected]> * remove pub key for cosign Signed-off-by: zachaller <[email protected]> Signed-off-by: Justin Marquis <[email protected]> Signed-off-by: zachaller <[email protected]> Co-authored-by: zachaller <[email protected]> Signed-off-by: Travis Perdue <[email protected]>
Signed-off-by: Justin Marquis [email protected]
This PR fixes the checksum generation done during a release. Also included SBOM to be signed. Cosign public key added for public record.
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.