Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump notification engine #2470

Merged
merged 7 commits into from
Dec 13, 2022

Conversation

zachaller
Copy link
Collaborator

@zachaller zachaller commented Dec 12, 2022

Supersedes:
closes: #2029

Signed-off-by: zachaller [email protected]

Signed-off-by: zachaller <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2022

E2E Tests Published Test Results

    2 files      2 suites   1h 37m 7s ⏱️
  94 tests   86 ✔️ 3 💤 5
196 runs  183 ✔️ 6 💤 7

For more details on these failures, see this check.

Results for commit b462983.

♻️ This comment has been updated with latest results.

@zachaller zachaller changed the title deps: bump notification engine chore(deps): bump notification engine Dec 12, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2022

Go Published Test Results

1 832 tests   1 832 ✔️  2m 30s ⏱️
   105 suites         0 💤
       1 files           0

Results for commit b462983.

♻️ This comment has been updated with latest results.

Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
@zachaller zachaller requested a review from leoluz December 12, 2022 19:04
Signed-off-by: zachaller <[email protected]>
@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 81.67% // Head: 81.67% // No change to project coverage 👍

Coverage data is based on head (b462983) compared to base (3c1038b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2470   +/-   ##
=======================================
  Coverage   81.67%   81.67%           
=======================================
  Files         126      126           
  Lines       19124    19124           
=======================================
  Hits        15620    15620           
  Misses       2710     2710           
  Partials      794      794           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoluz leoluz merged commit 1affe89 into argoproj:master Dec 13, 2022
tperdue321 pushed a commit to rallyhealth/argo-rollouts that referenced this pull request Jan 12, 2023
* bump notification engine

Signed-off-by: zachaller <[email protected]>

* github trigger re-run

Signed-off-by: zachaller <[email protected]>

* go tidy

Signed-off-by: zachaller <[email protected]>

* github trigger re-run

Signed-off-by: zachaller <[email protected]>

* codegen

Signed-off-by: zachaller <[email protected]>

* codegen and docs

Signed-off-by: zachaller <[email protected]>

Signed-off-by: zachaller <[email protected]>
Signed-off-by: Travis Perdue <[email protected]>
tperdue321 pushed a commit to rallyhealth/argo-rollouts that referenced this pull request Jan 12, 2023
* bump notification engine

Signed-off-by: zachaller <[email protected]>

* github trigger re-run

Signed-off-by: zachaller <[email protected]>

* go tidy

Signed-off-by: zachaller <[email protected]>

* github trigger re-run

Signed-off-by: zachaller <[email protected]>

* codegen

Signed-off-by: zachaller <[email protected]>

* codegen and docs

Signed-off-by: zachaller <[email protected]>

Signed-off-by: zachaller <[email protected]>
Signed-off-by: Travis Perdue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants