Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trafficrouting): Backport traffic routing fix #2441 #2449

Closed
wants to merge 12 commits into from

Conversation

MarkSRobinson
Copy link
Contributor

@MarkSRobinson MarkSRobinson commented Dec 2, 2022

This backports #2441 to the 1.3 release so that users can test it without running a 1.4 build.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@MarkSRobinson MarkSRobinson changed the title Appy Backport traffic routing fix Dec 2, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

E2E Tests Published Test Results

88 tests   85 ✔️  44m 30s ⏱️
  1 suites    3 💤
  1 files      0

Results for commit c17ce32.

@MarkSRobinson MarkSRobinson marked this pull request as ready for review December 4, 2022 22:02
@zachaller zachaller changed the title Backport traffic routing fix fix(trafficrouting): Backport traffic routing fix #2441 Dec 5, 2022
@zachaller
Copy link
Collaborator

The PR has deviated quite a bit from this so going to close this and will work on cherry picking #2441 into 1.3

@zachaller zachaller closed this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants