fix: add patch verb to deployment resource #2407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 81.55% // Head: 81.55% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2407 +/- ##
=======================================
Coverage 81.55% 81.55%
=======================================
Files 124 124
Lines 18931 18931
=======================================
Hits 15439 15439
Misses 2702 2702
Partials 790 790 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tukak
changed the title
Dashboard fails with ```failed restoring revision 21: deployments.apps "ourapp" is forbidden: User "system:serviceaccount:argo-rollouts:argo-rollouts-dashboard" cannot patch resource "deployments" in API group "apps" in the namespace "ournamespace"``` when trying to rollback `Rollout` defined using existing `Deployment` and `workloadRef` config. Adding `patch` verb for `deployments` should fix it. Signed-off-by: tukak <[email protected]>
|
Can you run |
Signed-off-by: tukak <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
@zachaller thanks for the hint, it passes now |
zachaller
approved these changes
Nov 14, 2022
thedevelopnik
pushed a commit
to thedevelopnik/argo-rollouts
that referenced
this pull request
Nov 17, 2022
* Add patch verb to deployment resource Dashboard fails with ```failed restoring revision 21: deployments.apps "ourapp" is forbidden: User "system:serviceaccount:argo-rollouts:argo-rollouts-dashboard" cannot patch resource "deployments" in API group "apps" in the namespace "ournamespace"``` when trying to rollback `Rollout` defined using existing `Deployment` and `workloadRef` config. Adding `patch` verb for `deployments` should fix it. Signed-off-by: tukak <[email protected]> * Generate dashboard-manifest.yaml Signed-off-by: tukak <[email protected]> Signed-off-by: tukak <[email protected]> Signed-off-by: Dave Sudia <[email protected]>
jandersen-plaid
pushed a commit
to jandersen-plaid/argo-rollouts
that referenced
this pull request
Nov 26, 2022
* Add patch verb to deployment resource Dashboard fails with ```failed restoring revision 21: deployments.apps "ourapp" is forbidden: User "system:serviceaccount:argo-rollouts:argo-rollouts-dashboard" cannot patch resource "deployments" in API group "apps" in the namespace "ournamespace"``` when trying to rollback `Rollout` defined using existing `Deployment` and `workloadRef` config. Adding `patch` verb for `deployments` should fix it. Signed-off-by: tukak <[email protected]> * Generate dashboard-manifest.yaml Signed-off-by: tukak <[email protected]> Signed-off-by: tukak <[email protected]>
Gallardot
pushed a commit
to Gallardot/argo-rollouts
that referenced
this pull request
Nov 27, 2022
* Add patch verb to deployment resource Dashboard fails with ```failed restoring revision 21: deployments.apps "ourapp" is forbidden: User "system:serviceaccount:argo-rollouts:argo-rollouts-dashboard" cannot patch resource "deployments" in API group "apps" in the namespace "ournamespace"``` when trying to rollback `Rollout` defined using existing `Deployment` and `workloadRef` config. Adding `patch` verb for `deployments` should fix it. Signed-off-by: tukak <[email protected]> * Generate dashboard-manifest.yaml Signed-off-by: tukak <[email protected]> Signed-off-by: tukak <[email protected]> Signed-off-by: Gallardot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dashboard fails with
failed restoring revision 21: deployments.apps "ourapp" is forbidden: User "system:serviceaccount:argo-rollouts:argo-rollouts-dashboard" cannot patch resource "deployments" in API group "apps" in the namespace "ournamespace"when trying to rollbackRolloutdefined using existingDeploymentandworkloadRefconfig. Addingpatchverb fordeploymentsshould fix it.Checklist:
"fix(controller): Updates such and such. Fixes #1234".