Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: create stable tag for docs #2402

Merged
merged 5 commits into from
Dec 13, 2022
Merged

Conversation

zachaller
Copy link
Collaborator

@zachaller zachaller commented Nov 8, 2022

Create a stable tag so that docs do not track latest causing confusion for end users on what features are available.

Signed-off-by: zachaller [email protected]

Create a stable tag so that docs do not track latest causing
confusion for end users on what features are available.

Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Nov 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Go Published Test Results

1 832 tests   1 832 ✔️  2m 31s ⏱️
   105 suites         0 💤
       1 files           0

Results for commit 5e4c156.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 81.58% // Head: 81.67% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (5e4c156) compared to base (998ab09).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2402      +/-   ##
==========================================
+ Coverage   81.58%   81.67%   +0.09%     
==========================================
  Files         124      126       +2     
  Lines       18959    19124     +165     
==========================================
+ Hits        15467    15620     +153     
- Misses       2702     2710       +8     
- Partials      790      794       +4     
Impacted Files Coverage Δ
utils/defaults/defaults.go 89.10% <0.00%> (ø)
utils/apisix/apisix.go 100.00% <0.00%> (ø)
rollout/trafficrouting/apisix/apisix.go 90.40% <0.00%> (ø)
utils/replicaset/replicaset.go 88.32% <0.00%> (+0.05%) ⬆️
rollout/trafficrouting.go 76.22% <0.00%> (+0.74%) ⬆️
rollout/service.go 78.97% <0.00%> (+1.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

E2E Tests Published Test Results

    2 files      2 suites   1h 34m 29s ⏱️
  94 tests   91 ✔️ 3 💤 0
188 runs  182 ✔️ 6 💤 0

Results for commit 5e4c156.

♻️ This comment has been updated with latest results.

@zachaller zachaller added this to the v1.4 milestone Nov 9, 2022
@zachaller zachaller marked this pull request as ready for review December 8, 2022 14:33
@zachaller zachaller marked this pull request as draft December 8, 2022 14:37
@zachaller zachaller marked this pull request as ready for review December 12, 2022 21:21
@zachaller zachaller requested a review from leoluz December 13, 2022 19:48
@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.6% 0.6% Duplication

Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaller zachaller merged commit 36b3b2e into argoproj:master Dec 13, 2022
tperdue321 pushed a commit to rallyhealth/argo-rollouts that referenced this pull request Jan 12, 2023
* ci: create stable tag for docs

Create a stable tag so that docs do not track latest causing
confusion for end users on what features are available.

Signed-off-by: zachaller <[email protected]>

* remove extra space

Signed-off-by: zachaller <[email protected]>

* no need to run pages build

Signed-off-by: zachaller <[email protected]>

* no need to add message keep tags lightweight

Signed-off-by: zachaller <[email protected]>

Signed-off-by: zachaller <[email protected]>
Signed-off-by: Travis Perdue <[email protected]>
tperdue321 pushed a commit to rallyhealth/argo-rollouts that referenced this pull request Jan 12, 2023
* ci: create stable tag for docs

Create a stable tag so that docs do not track latest causing
confusion for end users on what features are available.

Signed-off-by: zachaller <[email protected]>

* remove extra space

Signed-off-by: zachaller <[email protected]>

* no need to run pages build

Signed-off-by: zachaller <[email protected]>

* no need to add message keep tags lightweight

Signed-off-by: zachaller <[email protected]>

Signed-off-by: zachaller <[email protected]>
Signed-off-by: Travis Perdue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants