fix(analysis): Fix Analysis Terminal Decision For Dry-Run Metrics #2399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohit Agrawal <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportBase: 82.76% // Head: 82.76% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2399 +/- ##
=======================================
Coverage 82.76% 82.76%
=======================================
Files 121 121
Lines 18537 18539 +2
=======================================
+ Hits 15342 15344 +2
Misses 2410 2410
Partials 785 785
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
zachaller
approved these changes
Nov 8, 2022
jandersen-plaid
pushed a commit
to jandersen-plaid/argo-rollouts
that referenced
this pull request
Nov 8, 2022
…goproj#2399) Signed-off-by: Rohit Agrawal <[email protected]> Signed-off-by: Rohit Agrawal <[email protected]>
jandersen-plaid
pushed a commit
to jandersen-plaid/argo-rollouts
that referenced
this pull request
Nov 26, 2022
…goproj#2399) Signed-off-by: Rohit Agrawal <[email protected]> Signed-off-by: Rohit Agrawal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently came across a bug in the Analysis Run with both the Dry as well as Wet metrics where the terminal decision was being made based on the metric ordering and since we are simply returning in case of a Dry-Run metric failure, it was shadowing the Wet-Run failures by not correctly terminating the Analysis Run.
The fix is to simply continue the loop and keep looking for any Wet-Run metric failures by ignoring the failures from Dry-Run metrics inside
IsTerminating(...).Checklist
"fix(controller): Updates such and such. Fixes #1234".