Add analysis to RolloutExperimentStep #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
==========================================
+ Coverage 85.26% 85.28% +0.02%
==========================================
Files 49 49
Lines 4390 4398 +8
==========================================
+ Hits 3743 3751 +8
Misses 460 460
Partials 187 187
Continue to review full report at Codecov.
|
jessesuen
approved these changes
Oct 30, 2019
jessesuen
requested changes
Oct 30, 2019
pkg/apis/rollouts/v1alpha1/types.go
Outdated
| @@ -152,7 +152,8 @@ type RolloutExperimentStep struct { | |||
| Duration int32 `json:"duration"` | |||
| // Templates what templates that should be added to the experiment. Should be non-nil | |||
| Templates []RolloutExperimentTemplate `json:"templates"` | |||
| //ProgressingDeadlineSeconds Is it ncessary? | |||
| //AnalysisTemplate what analysis to run with the experiment | |||
| Analysis *RolloutAnalysisStep `json:"analysis,omitempty"` | |||
There was a problem hiding this comment.
Shouldn't this be a list of []ExperimentAnalysisTemplateRef and be named analyses? This approach means we only support one analysis per experiment step.
There was a problem hiding this comment.
I agree with having multiple analyses, but the ExperimentAnalysisTemplateRef doesn't work because it doesn't allow us to inject dynamic values (like podHash) into the analysis.
dthomson25
force-pushed
the
add-analysis-to-exp-step
branch
from
26f77e6 to
4327aa8
Compare
jessesuen
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.