Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where a ReplicaSet name collision could cause hot loop #236

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

jessesuen
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #236 into master will increase coverage by 0.06%.
The diff coverage is 94.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
+ Coverage   84.87%   84.94%   +0.06%     
==========================================
  Files          47       47              
  Lines        4272     4257      -15     
==========================================
- Hits         3626     3616      -10     
+ Misses        456      455       -1     
+ Partials      190      186       -4
Impacted Files Coverage Δ
experiments/experiment.go 93.9% <100%> (+1.43%) ⬆️
experiments/replicaset.go 77.2% <93.54%> (+1.59%) ⬆️
rollout/controller.go 69.56% <0%> (-3.11%) ⬇️
rollout/replicaset.go 76.19% <0%> (-0.83%) ⬇️
analysis/analysis.go 86.61% <0%> (-0.33%) ⬇️
rollout/canary.go 86.29% <0%> (+0.05%) ⬆️
utils/conditions/conditions.go 89.13% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1486519...2fd64f3. Read the comment docs.

Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessesuen jessesuen force-pushed the name-collision-label-check branch from f6bd0d6 to f9c8d94 Compare October 29, 2019 20:08
@jessesuen jessesuen force-pushed the name-collision-label-check branch from f9c8d94 to 2fd64f3 Compare October 29, 2019 20:10
@jessesuen jessesuen merged commit 773f933 into argoproj:master Oct 29, 2019
@jessesuen jessesuen deleted the name-collision-label-check branch October 29, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants