Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make active service required #235

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Conversation

dthomson25
Copy link
Member

closes #149

@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@b4837fe). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #235   +/-   ##
=========================================
  Coverage          ?   84.81%           
=========================================
  Files             ?       47           
  Lines             ?     4241           
  Branches          ?        0           
=========================================
  Hits              ?     3597           
  Misses            ?      455           
  Partials          ?      189
Impacted Files Coverage Δ
utils/conditions/conditions.go 88.95% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4837fe...4ad6211. Read the comment docs.

@dthomson25 dthomson25 merged commit 73c9c2d into master Oct 29, 2019
@dthomson25 dthomson25 deleted the make-active-service-required branch October 29, 2019 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenAPI validation should mark .spec.strategy.blueGreen.activeService as required
2 participants