Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil ptr for newRS #233

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Fix nil ptr for newRS #233

merged 1 commit into from
Oct 29, 2019

Conversation

dthomson25
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 28, 2019

Codecov Report

Merging #233 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
+ Coverage   84.82%   84.83%   +<.01%     
==========================================
  Files          47       47              
  Lines        4244     4246       +2     
==========================================
+ Hits         3600     3602       +2     
  Misses        455      455              
  Partials      189      189
Impacted Files Coverage Δ
rollout/canary.go 86.23% <ø> (-0.06%) ⬇️
rollout/replicaset.go 77.01% <100%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30cf6ab...83ae643. Read the comment docs.

@dthomson25 dthomson25 merged commit 1f7f1a2 into master Oct 29, 2019
@dthomson25 dthomson25 deleted the fix-nil-ptr branch October 29, 2019 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants