Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Use new Google Analytics 4 site tag #2299

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Oct 7, 2022

  • Contributes to Migrate to Google Analytics 4 (GA4) argo-site#102
  • As mentioned in that umbrella issue, the UA site tag originally assigned to the site (which hasn't been active since 2021/07/03) is now connected from the new GA4 site tag and so will continue receiving events. In fact, it will start receiving consolidated events forwarded from the GA4 site tag.

/cc @alexmt @alexec


Note that analytics for UA-105170809-3 was disabled in July 2021 (inadvertently?) via:

@chalin chalin force-pushed the chalin-gp-ga4-2022-10-07 branch from 64fc1f6 to 409260e Compare October 7, 2022 18:16
@sonarcloud
Copy link

sonarcloud bot commented Oct 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

Go Published Test Results

1 772 tests   1 772 ✔️  2m 33s ⏱️
   101 suites         0 💤
       1 files           0

Results for commit 409260e.

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Base: 82.38% // Head: 82.38% // No change to project coverage 👍

Coverage data is based on head (409260e) compared to base (33ddaf5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2299   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         121      121           
  Lines       18476    18476           
=======================================
  Hits        15221    15221           
  Misses       2468     2468           
  Partials      787      787           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

E2E Tests Published Test Results

  1 files    1 suites   44m 41s ⏱️
89 tests 84 ✔️ 3 💤 2
91 runs  86 ✔️ 3 💤 2

For more details on these failures, see this check.

Results for commit 409260e.

Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you

@alexmt alexmt merged commit 1394f4e into argoproj:master Oct 7, 2022
@chalin chalin deleted the chalin-gp-ga4-2022-10-07 branch October 7, 2022 19:24
jenciso pushed a commit to jenciso/argo-rollouts that referenced this pull request Oct 25, 2022
Signed-off-by: Patrice Chalin <[email protected]>

Signed-off-by: Patrice Chalin <[email protected]>
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 8, 2022
Signed-off-by: Patrice Chalin <[email protected]>

Signed-off-by: Patrice Chalin <[email protected]>
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 26, 2022
Signed-off-by: Patrice Chalin <[email protected]>

Signed-off-by: Patrice Chalin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants