Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix minor mistakes in Migrating to Deployments #2270

Merged
merged 1 commit into from
Jun 15, 2023
Merged

docs: fix minor mistakes in Migrating to Deployments #2270

merged 1 commit into from
Jun 15, 2023

Conversation

gmiroshnykov
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2022 •
edited
Loading

Go Published Test Results

1 988 tests   1 988 ✔️  2m 35s ⏱️
   118 suites         0 💤
       1 files           0 ❌

Results for commit 228c0a4.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Sep 27, 2022 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (ded934b) 81.67% compared to head (d370c6c) 81.68%.

❗ Current head d370c6c differs from pull request most recent head 228c0a4. Consider uploading reports for the commit 228c0a4 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2270      +/-   ##
==========================================
+ Coverage   81.67%   81.68%   +0.01%     
==========================================
  Files         133      133              
  Lines       20188    20178      -10     
==========================================
- Hits        16489    16483       -6     
+ Misses       2847     2843       -4     
  Partials      852      852

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2022 •
edited
Loading

E2E Tests Published Test Results

    4 files      4 suites   3h 32m 44s ⏱️
  96 tests   83 ✔️   5 💤   8 ❌
396 runs  364 ✔️ 20 💤 12 ❌

For more details on these failures, see this check.

Results for commit 228c0a4.

♻️ This comment has been updated with latest results.

@gmiroshnykov gmiroshnykov force-pushed the docs-migrating-mistake branch 2 times, most recently from 4c92329 to a104f55 Compare September 30, 2022 14:47
@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
18.5% 18.5% Duplication

@github-actions
Copy link
Contributor

This PR is stale because it has been open 90 days with no activity.

agrawroh
agrawroh reviewed Dec 30, 2022
View reviewed changes
Copy link
Member

@agrawroh agrawroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworded some of the statements to make it a little cleaner and avoid redundant words.

docs/migrating.md Outdated Show resolved Hide resolved
docs/migrating.md Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
18.5% 18.5% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2023

This PR is stale because it has been open 90 days with no activity.

@gmiroshnykov gmiroshnykov force-pushed the docs-migrating-mistake branch from 29f47d5 to 99efb3a Compare April 2, 2023 09:29
@gmiroshnykov gmiroshnykov force-pushed the docs-migrating-mistake branch 3 times, most recently from b800582 to 0223b7e Compare April 6, 2023 07:57
agrawroh
agrawroh approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@agrawroh agrawroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good, Thanks!

@gmiroshnykov gmiroshnykov force-pushed the docs-migrating-mistake branch from 0223b7e to 508c55d Compare April 17, 2023 20:11
@gmiroshnykov gmiroshnykov requested a review from agrawroh May 23, 2023 21:04
@gmiroshnykov gmiroshnykov force-pushed the docs-migrating-mistake branch from d370c6c to 228c0a4 Compare June 14, 2023 20:39
@sonarcloud
Copy link

sonarcloud bot commented Jun 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.9% 8.9% Duplication

@agrawroh
Copy link
Member

cc @zachaller Can you help merge this PR?

@zachaller zachaller merged commit 9bd26c6 into argoproj:master Jun 15, 2023
@zachaller
Copy link
Collaborator

@agrawroh thanks for the ping, also @gmiroshnykov thanks for the contrib

@gmiroshnykov gmiroshnykov deleted the docs-migrating-mistake branch June 15, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostis-codefresh kostis-codefresh kostis-codefresh approved these changes

@agrawroh agrawroh agrawroh approved these changes

@zachaller zachaller zachaller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gmiroshnykov @agrawroh @zachaller @kostis-codefresh