Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: imports: remove repeated package and reformat imports #2183

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

ShirleyDing
Copy link
Contributor

@ShirleyDing ShirleyDing commented Aug 9, 2022

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

Go Published Test Results

1 731 tests   1 731 ✔️  2m 32s ⏱️
   101 suites         0 💤
       1 files           0

Results for commit 9d60d7a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

E2E Tests Published Test Results

88 tests   85 ✔️  45m 18s ⏱️
  1 suites    3 💤
  1 files      0

Results for commit 9d60d7a.

♻️ This comment has been updated with latest results.

@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #2183 (9d60d7a) into master (25f40d2) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2183      +/-   ##
==========================================
- Coverage   82.39%   82.37%   -0.02%     
==========================================
  Files         121      121              
  Lines       18073    18073              
==========================================
- Hits        14891    14888       -3     
- Misses       2414     2416       +2     
- Partials      768      769       +1     
Impacted Files Coverage Δ
controller/controller.go 89.45% <100.00%> (ø)
rollout/trafficrouting/istio/controller.go 50.81% <0.00%> (-1.63%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zachaller zachaller added the ready-for-review Ready for final review label Sep 9, 2022
Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoluz leoluz merged commit 6aa8ee8 into argoproj:master Sep 26, 2022
daixijun pushed a commit to daixijun/argo-rollouts that referenced this pull request Sep 27, 2022
Signed-off-by: Shirley Ding <[email protected]>

Signed-off-by: Shirley Ding <[email protected]>
Signed-off-by: Xijun Dai <[email protected]>
jenciso pushed a commit to jenciso/argo-rollouts that referenced this pull request Oct 25, 2022
@zachaller zachaller changed the title chore imports: remove repeated package and reformat imports chore: imports: remove repeated package and reformat imports Nov 8, 2022
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 8, 2022
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review Ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants