Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pausing #211

Merged
merged 16 commits into from
Oct 22, 2019
Merged

Refactor pausing #211

merged 16 commits into from
Oct 22, 2019

Conversation

dthomson25
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 20, 2019

Codecov Report

Merging #211 into master will increase coverage by 0.06%.
The diff coverage is 94.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
+ Coverage    84.4%   84.47%   +0.06%     
==========================================
  Files          47       47              
  Lines        3951     3993      +42     
==========================================
+ Hits         3335     3373      +38     
- Misses        439      442       +3     
- Partials      177      178       +1
Impacted Files Coverage Δ
utils/replicaset/replicaset.go 88.76% <100%> (ø) ⬆️
rollout/service.go 91.39% <100%> (-0.1%) ⬇️
rollout/context.go 97.56% <100%> (+0.5%) ⬆️
pkg/kubectl-argo-rollouts/cmd/resume/resume.go 100% <100%> (ø) ⬆️
rollout/canary.go 86.06% <100%> (+0.17%) ⬆️
rollout/pause.go 100% <100%> (+3.63%) ⬆️
rollout/controller.go 69.56% <100%> (-0.44%) ⬇️
rollout/analysis.go 83.21% <66.66%> (+0.24%) ⬆️
rollout/sync.go 76.5% <84.09%> (-1.34%) ⬇️
rollout/bluegreen.go 80.58% <93.1%> (+1.58%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57b9c47...79bbbea. Read the comment docs.

pkg/apis/rollouts/v1alpha1/types.go Outdated Show resolved Hide resolved
pkg/kubectl-argo-rollouts/cmd/resume/resume.go Outdated Show resolved Hide resolved
rollout/bluegreen.go Outdated Show resolved Hide resolved
rollout/controller.go Show resolved Hide resolved
rollout/canary.go Outdated Show resolved Hide resolved
utils/replicaset/replicaset.go Show resolved Hide resolved
rollout/sync.go Show resolved Hide resolved
rollout/sync.go Outdated Show resolved Hide resolved
Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think only remaining items were:

  • get rid of "Run" so that it's just "InconclusiveAnalysis". Alternatively, we can name it: AnalysisInconclusive
  • the CLI cannot resume a paused rollout that I paused myself

User pause can be done as separate review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants