-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor pausing #211
Refactor pausing #211
Conversation
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
==========================================
+ Coverage 84.4% 84.47% +0.06%
==========================================
Files 47 47
Lines 3951 3993 +42
==========================================
+ Hits 3335 3373 +38
- Misses 439 442 +3
- Partials 177 178 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think only remaining items were:
- get rid of "Run" so that it's just "InconclusiveAnalysis". Alternatively, we can name it:
AnalysisInconclusive
- the CLI cannot resume a paused rollout that I paused myself
User pause can be done as separate review.
No description provided.