Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change bug template to bring inline with argocd #2096

Merged
merged 4 commits into from
Jun 23, 2022
Merged

Change bug template to bring inline with argocd #2096

merged 4 commits into from
Jun 23, 2022

Conversation

zachaller
Copy link
Collaborator

No description provided.

zachaller added 3 commits June 14, 2022 14:59
@zachaller
add back maintainers note
f5551e2 
Signed-off-by: zachaller <[email protected]>
@zachaller
Missed a bit
264bce1 
Signed-off-by: zachaller <[email protected]>
@zachaller
keep line
0b4714e 
Signed-off-by: zachaller <[email protected]>
@codecov
Copy link

codecov bot commented Jun 14, 2022 •
edited
Loading

Codecov Report

Merging #2096 (fe540e9) into master (a6dbe0e) will not change coverage.
The diff coverage is n/a.

❗ Current head fe540e9 differs from pull request most recent head 0b4714e. Consider uploading reports for the commit 0b4714e to get more accurate results

@@           Coverage Diff           @@
##           master    #2096   +/-   ##
=======================================
  Coverage   82.43%   82.43%           
=======================================
  Files         120      120           
  Lines       17440    17440           
=======================================
  Hits        14376    14376           
  Misses       2352     2352           
  Partials      712      712

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6dbe0e...0b4714e. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jun 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

leoluz
leoluz approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harikrongali harikrongali added this to the v1.3 milestone Jun 22, 2022
@leoluz leoluz merged commit 5c32e84 into argoproj:master Jun 23, 2022
jenciso pushed a commit to jenciso/argo-rollouts that referenced this pull request Oct 25, 2022
@zachaller @jenciso
Change bug template to bring inline with argocd (argoproj#2096)
14bbc4b 
* Change bug template to bring inline with argocd?

Signed-off-by: zachaller <[email protected]>

* add back maintainers note

Signed-off-by: zachaller <[email protected]>

* Missed a bit

Signed-off-by: zachaller <[email protected]>

* keep line

Signed-off-by: zachaller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harikrongali harikrongali harikrongali approved these changes

@leoluz leoluz leoluz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@zachaller @leoluz @harikrongali