Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: High reconciliation activity and CPU load for invalid rollout #2091

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

perenesenko
Copy link
Member

@perenesenko perenesenko commented Jun 10, 2022

Signed-off-by: Andrii Perenesenko [email protected]

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@perenesenko
Copy link
Member Author

Fix for #2023

@sonarcloud
Copy link

sonarcloud bot commented Jun 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.4% 3.4% Duplication

@perenesenko perenesenko linked an issue Jun 10, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #2091 (e0eba31) into master (3f5960e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2091   +/-   ##
=======================================
  Coverage   82.43%   82.43%           
=======================================
  Files         120      120           
  Lines       17440    17440           
=======================================
  Hits        14376    14376           
  Misses       2352     2352           
  Partials      712      712           
Impacted Files Coverage Δ
pkg/apis/rollouts/validation/validation.go 94.94% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f5960e...e0eba31. Read the comment docs.

@harikrongali harikrongali added this to the v1.3 milestone Jun 22, 2022
@leoluz leoluz merged commit e53e889 into argoproj:master Jun 23, 2022
jenciso pushed a commit to jenciso/argo-rollouts that referenced this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High reconciliation activity and CPU load for invalid rollout
4 participants