Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames golang field names for blueGreen/canary to eliminate two API violations #206

Merged
merged 1 commit into from
Oct 17, 2019

Conversation

jessesuen
Copy link
Member

Fixes two API violations since the golang field names did not match the API spec. I think it's too late to remove the HPAReplicas violation. The json field name should have been hpaReplicas and not HPAReplicas.

@jessesuen jessesuen requested a review from dthomson25 October 16, 2019 23:27
@codecov
Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #206 into master will not change coverage.
The diff coverage is 95.29%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #206   +/-   ##
=======================================
  Coverage   84.33%   84.33%           
=======================================
  Files          47       47           
  Lines        3945     3945           
=======================================
  Hits         3327     3327           
  Misses        441      441           
  Partials      177      177
Impacted Files Coverage Δ
rollout/sync.go 77.83% <100%> (ø) ⬆️
utils/replicaset/canary.go 67.91% <100%> (ø) ⬆️
pkg/kubectl-argo-rollouts/cmd/list/rollloutinfo.go 90% <100%> (ø) ⬆️
rollout/canary.go 85.89% <100%> (ø) ⬆️
rollout/pause.go 96.36% <100%> (ø) ⬆️
rollout/analysis.go 82.96% <100%> (ø) ⬆️
rollout/controller.go 70% <100%> (ø) ⬆️
utils/defaults/defaults.go 100% <100%> (ø) ⬆️
rollout/service.go 91.48% <100%> (ø) ⬆️
utils/service/service.go 100% <100%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c653df...b405b04. Read the comment docs.

Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessesuen jessesuen merged commit c19c2c2 into argoproj:master Oct 17, 2019
@jessesuen jessesuen deleted the rename-bg-canary-field-names branch October 17, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants