Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rollout Context to reconcilization loop #205

Merged
merged 3 commits into from
Oct 16, 2019
Merged

Conversation

dthomson25
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #205 into master will increase coverage by 0.45%.
The diff coverage is 93.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
+ Coverage   83.79%   84.24%   +0.45%     
==========================================
  Files          44       45       +1     
  Lines        3665     3784     +119     
==========================================
+ Hits         3071     3188     +117     
- Misses        423      425       +2     
  Partials      171      171
Impacted Files Coverage Δ
rollout/service.go 91.48% <100%> (+0.58%) ⬆️
rollout/replicaset.go 76.19% <100%> (+1.19%) ⬆️
rollout/experiment.go 83.33% <73.68%> (+0.33%) ⬆️
rollout/pause.go 96.36% <83.33%> (+0.2%) ⬆️
rollout/bluegreen.go 79% <88.09%> (+1.1%) ⬆️
rollout/analysis.go 82.96% <92.5%> (+1.21%) ⬆️
rollout/sync.go 77.83% <94.44%> (+0.36%) ⬆️
rollout/context.go 97.05% <97.05%> (ø)
rollout/canary.go 85.89% <98.3%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75ea342...b6d86b0. Read the comment docs.

Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already much cleaner!

@dthomson25 dthomson25 merged commit 9c653df into master Oct 16, 2019
@dthomson25 dthomson25 deleted the context-refactor branch October 16, 2019 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants