Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement list command in kubectl plugin #204

Merged
merged 1 commit into from
Oct 16, 2019

Conversation

jessesuen
Copy link
Member

@jessesuen jessesuen commented Oct 16, 2019

Example output:

$ go run cmd/kubectl-argo-rollouts/main.go list --all-namespaces
NAMESPACE      NAME                         STRATEGY    STATUS        STEP  SET-WEIGHT  READY  DESIRED  UP-TO-DATE  AVAILABLE
default        canary-demo                  Canary      Progressing   2/3   20          5/5    5        1           5
default        rollout-test-helm-guestbook  BlueGreen   Healthy       -     -           1/1    1        1           1
istio-rollout  istio-rollout                Canary      Degraded      1/2   20          5/5    5        1           5
nginx-rollout  nginx-rollout                Canary      Degraded      1/2   20          5/5    5        1           5

@jessesuen jessesuen requested a review from dthomson25 October 16, 2019 01:38
@codecov
Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #204 into master will decrease coverage by 0.3%.
The diff coverage is 86.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
- Coverage   83.79%   83.48%   -0.31%     
==========================================
  Files          44       45       +1     
  Lines        3665     3700      +35     
==========================================
+ Hits         3071     3089      +18     
- Misses        423      441      +18     
+ Partials      171      170       -1
Impacted Files Coverage Δ
pkg/kubectl-argo-rollouts/cmd/cmd.go 100% <100%> (ø) ⬆️
pkg/kubectl-argo-rollouts/cmd/list/list.go 84% <84%> (ø)
pkg/kubectl-argo-rollouts/cmd/list/rollloutinfo.go 90% <90%> (ø)
rollout/controller.go 65.71% <0%> (-4.29%) ⬇️
utils/query/query.go 100% <0%> (ø) ⬆️
utils/analysis/filter.go 100% <0%> (ø) ⬆️
utils/experiment/experiment.go 100% <0%> (ø) ⬆️
utils/experiment/filter.go
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75ea342...2d42f25. Read the comment docs.

Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessesuen jessesuen merged commit bdbf1aa into argoproj:master Oct 16, 2019
@jessesuen jessesuen deleted the list-cmd branch October 16, 2019 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants