-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Ability for lint command to inspect referenced resources #2030
Conversation
Signed-off-by: zachaller <[email protected]>
…fest Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2030 +/- ##
==========================================
+ Coverage 82.42% 82.60% +0.18%
==========================================
Files 119 120 +1
Lines 16913 17176 +263
==========================================
+ Hits 13940 14188 +248
- Misses 2282 2284 +2
- Partials 691 704 +13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should only lint with the available resources that we currently have. We can't translate the exact validation that happens server-side in the client.
Signed-off-by: zachaller <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…roj#2030) Signed-off-by: zachaller <[email protected]>
This is the first half of adding the ability for the lint cmd to reference other resources. It currently supports Ingress, VirtualServices, and Services.