Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ability for lint command to inspect referenced resources #2030

Merged
merged 8 commits into from
May 25, 2022

Conversation

zachaller
Copy link
Collaborator

This is the first half of adding the ability for the lint cmd to reference other resources. It currently supports Ingress, VirtualServices, and Services.

@zachaller zachaller marked this pull request as ready for review May 12, 2022 18:56
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #2030 (a5a5802) into master (4333b4f) will increase coverage by 0.18%.
The diff coverage is 91.55%.

@@            Coverage Diff             @@
##           master    #2030      +/-   ##
==========================================
+ Coverage   82.42%   82.60%   +0.18%     
==========================================
  Files         119      120       +1     
  Lines       16913    17176     +263     
==========================================
+ Hits        13940    14188     +248     
- Misses       2282     2284       +2     
- Partials      691      704      +13     
Impacted Files Coverage Δ
.../apis/rollouts/validation/validation_references.go 87.68% <ø> (-0.04%) ⬇️
pkg/kubectl-argo-rollouts/cmd/lint/lint.go 85.29% <91.55%> (+17.39%) ⬆️
metricproviders/prometheus/prometheus.go 96.42% <0.00%> (-3.58%) ⬇️
analysis/analysis.go 85.53% <0.00%> (-0.59%) ⬇️
utils/defaults/defaults.go 88.35% <0.00%> (ø)
utils/conditions/conditions.go 80.76% <0.00%> (ø)
rollout/trafficrouting/traefik/traefik.go 81.25% <0.00%> (ø)
utils/aws/aws.go 72.92% <0.00%> (+0.48%) ⬆️
rollout/trafficrouting.go 81.70% <0.00%> (+0.64%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4333b4f...a5a5802. Read the comment docs.

Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should only lint with the available resources that we currently have. We can't translate the exact validation that happens server-side in the client.

go.mod Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented May 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants