Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add WorkloadRef to Rollout spec #2019

Merged
merged 1 commit into from
May 4, 2022
Merged

Conversation

danielhelfand
Copy link
Contributor

Closes #2018

Adds WorkloadRef to Rollout spec documentation. While this closes the issue above, another issue should be opened to see if the Rollout spec docs are fully up to date.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@sonarcloud
Copy link

sonarcloud bot commented May 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #2019 (bee6710) into master (b115ea8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2019   +/-   ##
=======================================
  Coverage   82.50%   82.50%           
=======================================
  Files         120      120           
  Lines       17054    17054           
=======================================
  Hits        14070    14070           
  Misses       2283     2283           
  Partials      701      701           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b115ea8...bee6710. Read the comment docs.

@huikang huikang merged commit b364782 into argoproj:master May 4, 2022
PhilippPlotnikov pushed a commit to codefresh-contrib/argo-rollouts that referenced this pull request May 25, 2022
Signed-off-by: Daniel Helfand <[email protected]>
Signed-off-by: PhilippPlotnikov <[email protected]>
jenciso pushed a commit to jenciso/argo-rollouts that referenced this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: missing workloadRef in Rollout Specification doc
2 participants