Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(doc): Clarify doc for Rollout.spec.progressDeadlineAbort #1974

Merged
merged 2 commits into from
Apr 12, 2022
Merged

chore(doc): Clarify doc for Rollout.spec.progressDeadlineAbort #1974

merged 2 commits into from
Apr 12, 2022

Conversation

ivanov-vovan
Copy link
Contributor

Clarification for the progressDeadlineAbort parameter documentation.

@ivanov-vovan ivanov-vovan force-pushed the vivanov/rollout-spec-fix branch from c5f31b9 to 18213d8 Compare April 11, 2022 20:29
@codecov
Copy link

codecov bot commented Apr 11, 2022 •
edited
Loading

Codecov Report

Merging #1974 (3dee286) into master (a8ae46a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1974   +/-   ##
=======================================
  Coverage   82.42%   82.42%           
=======================================
  Files         119      119           
  Lines       16913    16913           
=======================================
  Hits        13940    13940           
  Misses       2282     2282           
  Partials      691      691

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8ae46a...3dee286. Read the comment docs.

@huikang
Copy link
Member

huikang commented Apr 11, 2022

@ivanov-vovan , could you update the comment of this variable as well?

argo-rollouts/pkg/apis/rollouts/v1alpha1/types.go

Lines 73 to 74 in a8ae46a

// ProgressDeadlineAbort is whether to abort the update when ProgressDeadlineSeconds
// is exceeded if analysis is not used. Default is false.

@jessesuen @alexmt @perenesenko, based on our experience, we think the ProgressDeadlineAbort is applicable to analysis and experiment as well. Could you help review the proposed change? Thanks.

@huikang
Copy link
Member

huikang commented Apr 11, 2022

@ivanov-vovan , I think you need to run make codegen to fix the failed Verify Codegen in ci.

@ivanov-vovan ivanov-vovan force-pushed the vivanov/rollout-spec-fix branch 2 times, most recently from 990a4be to 933629b Compare April 11, 2022 22:23
@ivanov-vovan
Copy link
Contributor Author

@huikang Thank you, ran codegen.

@ivanov-vovan ivanov-vovan force-pushed the vivanov/rollout-spec-fix branch from 933629b to 3dee286 Compare April 12, 2022 15:40
@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@huikang huikang merged commit b50a222 into argoproj:master Apr 12, 2022
@ivanov-vovan ivanov-vovan deleted the vivanov/rollout-spec-fix branch April 12, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huikang huikang huikang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanov-vovan @huikang