Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(RBAC): Add watch verb to clusterRole for pods. Fixes #1960 #1961

Merged
merged 1 commit into from
Apr 10, 2022
Merged

fix(RBAC): Add watch verb to clusterRole for pods. Fixes #1960 #1961

merged 1 commit into from
Apr 10, 2022

Conversation

ansilh
Copy link
Contributor

@ansilh ansilh commented Apr 6, 2022

Need pod watch argo rollouts get rollouts
Fixes #1960
Checklist:

  • this is a bug fix
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

huikang
huikang reviewed Apr 6, 2022
View reviewed changes
Copy link
Member

@huikang huikang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is generated from https://github.com/argoproj/argo-rollouts/blob/master/manifests/role/argo-rollouts-clusterrole.yaml. So please change in the source file. Thanks.

@codecov
Copy link

codecov bot commented Apr 6, 2022 •
edited
Loading

Codecov Report

Merging #1961 (be35e67) into master (4333b4f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1961   +/-   ##
=======================================
  Coverage   82.42%   82.42%           
=======================================
  Files         119      119           
  Lines       16913    16913           
=======================================
  Hits        13940    13940           
  Misses       2282     2282           
  Partials      691      691

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4333b4f...be35e67. Read the comment docs.

@ansilh
Copy link
Contributor Author

ansilh commented Apr 7, 2022

Thanks @huikang . Made the changes.

@huikang
Copy link
Member

huikang commented Apr 7, 2022

I think you also need to update manifests/namespace-install.yaml b/manifests/namespace-install.yaml to pass the CI.

@huikang
Copy link
Member

huikang commented Apr 9, 2022

could you also update this file manifests/namespace-install.yaml?

@sonarcloud
Copy link

sonarcloud bot commented Apr 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@huikang huikang merged commit 589e896 into argoproj:master Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huikang huikang huikang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Executing "argo rollouts get rollouts" from pod gives error.
2 participants
@ansilh @huikang