Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement argo rollouts kubectl plugin #195

Merged
merged 3 commits into from
Oct 11, 2019

Conversation

jessesuen
Copy link
Member

See below for examples:

$ kubectl argo rollouts version
kubectl-argo-rollouts: v0.5.0+71cfcca
  BuildDate: 2019-10-11T09:33:48Z
  GitCommit: 71cfcca753186304cfc39bc602d77358e7ad12ab
  GitTreeState: clean
  GoVersion: go1.13.1
  Compiler: gc
  Platform: darwin/amd64

$ kubectl argo rollouts resume canary-demo -n default
rollout 'canary-demo' resumed

$ kubectl argo rollouts pause canary-demo -n default
rollout 'canary-demo' paused

$ kubectl argo rollouts -v=6 resume doesnt-exist
I1011 02:36:12.660302   81169 loader.go:375] Config loaded from file:  /Users/jsuen/.kube/config
I1011 02:36:13.135455   81169 round_trippers.go:443] PATCH https://35.235.69.198/apis/argoproj.io/v1alpha1/namespaces/argo/rollouts/doesnt-exist 404 Not Found in 474 milliseconds
Error: rollouts.argoproj.io "doesnt-exist" not found

@jessesuen jessesuen requested a review from dthomson25 October 11, 2019 09:36
Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -705,15 +705,6 @@ spec:
type: integer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the manifest changing so much? Did we just forget to run the make manifests with the library change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea looks like I neglected to do it in this PR: fb287a4. It should have came in there.

options "github.com/argoproj/argo-rollouts/pkg/kubectl-argo-rollouts/options/fake"
)

func TestCmdArgoRolloutsCmdUsage(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the unit test here!

@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #195 into master will increase coverage by 0.43%.
The diff coverage is 88.8%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
+ Coverage    83.1%   83.53%   +0.43%     
==========================================
  Files          38       43       +5     
  Lines        3379     3480     +101     
==========================================
+ Hits         2808     2907      +99     
- Misses        415      417       +2     
  Partials      156      156
Impacted Files Coverage Δ
pkg/kubectl-argo-rollouts/cmd/pause/pause.go 100% <100%> (ø)
pkg/kubectl-argo-rollouts/cmd/resume/resume.go 100% <100%> (ø)
pkg/kubectl-argo-rollouts/cmd/cmd.go 100% <100%> (ø)
pkg/kubectl-argo-rollouts/cmd/version/version.go 100% <100%> (ø)
pkg/kubectl-argo-rollouts/options/options.go 72% <72%> (ø)
utils/experiment/experiment.go 100% <0%> (ø) ⬆️
rollout/controller.go 65.71% <0%> (ø) ⬆️
rollout/experiment.go 83.33% <0%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2114be0...18d3e37. Read the comment docs.

@jessesuen jessesuen merged commit e718402 into argoproj:master Oct 11, 2019
@jessesuen jessesuen deleted the kubectl-plugin branch October 11, 2019 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants