-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement argo rollouts kubectl plugin #195
Conversation
417df16
to
69b2940
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -705,15 +705,6 @@ spec: | |||
type: integer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the manifest changing so much? Did we just forget to run the make manifests with the library change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea looks like I neglected to do it in this PR: fb287a4. It should have came in there.
options "github.com/argoproj/argo-rollouts/pkg/kubectl-argo-rollouts/options/fake" | ||
) | ||
|
||
func TestCmdArgoRolloutsCmdUsage(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the unit test here!
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
+ Coverage 83.1% 83.53% +0.43%
==========================================
Files 38 43 +5
Lines 3379 3480 +101
==========================================
+ Hits 2808 2907 +99
- Misses 415 417 +2
Partials 156 156
Continue to review full report at Codecov.
|
See below for examples: