Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Dashboard displaying the setCanaryScale values #1923

Merged
merged 7 commits into from
Mar 30, 2022

Conversation

schakrad
Copy link
Contributor

@schakrad schakrad commented Mar 23, 2022

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.
    Before

Screen Shot 2022-03-23 at 1 45 23 PM

After

Screen Shot 2022-03-23 at 1 28 59 PM

Screen Shot 2022-03-23 at 1 32 24 PM

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #1923 (6e6375b) into master (676c865) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1923      +/-   ##
==========================================
+ Coverage   82.38%   82.40%   +0.01%     
==========================================
  Files         119      119              
  Lines       16872    16910      +38     
==========================================
+ Hits        13900    13934      +34     
- Misses       2282     2285       +3     
- Partials      690      691       +1     
Impacted Files Coverage Δ
rollout/trafficrouting/istio/controller.go 50.81% <0.00%> (-1.63%) ⬇️
controller/metrics/metrics.go 100.00% <0.00%> (ø)
controller/metrics/prommetrics.go 100.00% <0.00%> (ø)
utils/record/record.go 80.55% <0.00%> (+2.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 676c865...6e6375b. Read the comment docs.

@schakrad schakrad changed the title fix 1702 - Dashboard displaying the setCanaryScale values feature 1702 - Dashboard displaying the setCanaryScale values Mar 23, 2022
@schakrad schakrad changed the title feature 1702 - Dashboard displaying the setCanaryScale values feature1702-Dashboard displaying the setCanaryScale values Mar 23, 2022
@schakrad schakrad changed the title feature1702-Dashboard displaying the setCanaryScale values feature-Dashboard displaying the setCanaryScale values Mar 23, 2022
@schakrad schakrad changed the title feature-Dashboard displaying the setCanaryScale values feature: Dashboard displaying the setCanaryScale values Mar 23, 2022
@harikrongali harikrongali requested a review from rbreeze March 25, 2022 17:25
@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.6% 3.6% Duplication

Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit e89c97b into argoproj:master Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants