Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix golangci-lint to 1.44 to fix build error #1917

Merged
merged 1 commit into from
Mar 21, 2022
Merged

chore: fix golangci-lint to 1.44 to fix build error #1917

merged 1 commit into from
Mar 21, 2022

Conversation

jessesuen
Copy link
Member

@jessesuen jessesuen commented Mar 21, 2022 •
edited
Loading

Latest 1.45 version causes this failure in CI (I think due to multi-arch build on arm64):

#22 0.471 golangci/golangci-lint info checking GitHub for tag 'v1.45.0'
#22 0.834 golangci/golangci-lint info found version: 1.45.0 for v1.45.0/linux/arm64
#22 2.684 golangci/golangci-lint info installed /go/bin/golangci-lint
#22 14.16 panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt
#22 14.16
#22 14.16 goroutine 1 [running]:
#22 14.16 github.com/go-critic/go-critic/checkers.init.22()
#22 14.16       github.com/go-critic/[email protected]/checkers/embedded_rules.go:46 +0x488

Signed-off-by: Jesse Suen [email protected]

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.8% 3.8% Duplication

alexmt
alexmt approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessesuen jessesuen merged commit 08cf10e into argoproj:master Mar 21, 2022
ssanders1449 pushed a commit to ssanders1449/argo-rollouts that referenced this pull request Mar 28, 2022
@jessesuen
chore: fix golangci-lint to 1.44 to fix build error (argoproj#1917)
db06d7b 
Signed-off-by: Jesse Suen <[email protected]>
Signed-off-by: Shlomo Sanders <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbreeze rbreeze rbreeze approved these changes

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jessesuen @alexmt @rbreeze