Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify provider interfaces to set error messages #189

Merged
merged 2 commits into from
Oct 9, 2019

Conversation

jessesuen
Copy link
Member

  • Rename AnalysisProvider to MetricProvider
  • Add message field to measurements
  • Simplify provider interface so that it never returns error, and error messages are expected to be set in the measurement.

@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #189 into master will increase coverage by 0.05%.
The diff coverage is 95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
+ Coverage   82.69%   82.74%   +0.05%     
==========================================
  Files          34       35       +1     
  Lines        3189     3181       -8     
==========================================
- Hits         2637     2632       -5     
+ Misses        408      406       -2     
+ Partials      144      143       -1
Impacted Files Coverage Δ
metricproviders/job/job.go 100% <100%> (ø)
analysis/controller.go 50.64% <100%> (ø) ⬆️
utils/metric/metric.go 100% <100%> (ø)
metricproviders/prometheus/prometheus.go 100% <100%> (ø)
analysis/analysis.go 86.34% <81.81%> (+1.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b62d3e5...2a7092f. Read the comment docs.

Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

analysis/analysis.go Outdated Show resolved Hide resolved
providers/provider.go Show resolved Hide resolved
@dthomson25
Copy link
Member

Do we not have a unit test for executing the resume provider?

https://codecov.io/gh/argoproj/argo-rollouts/pull/189/diff#D11-194

Copy link
Member Author

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add a test for missing coverage

providers/provider.go Show resolved Hide resolved
@jessesuen jessesuen merged commit 3b6a907 into argoproj:master Oct 9, 2019
@jessesuen jessesuen deleted the analysis-refactor branch October 9, 2019 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants