-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify provider interfaces to set error messages #189
Conversation
jessesuen
commented
Oct 8, 2019
- Rename AnalysisProvider to MetricProvider
- Add message field to measurements
- Simplify provider interface so that it never returns error, and error messages are expected to be set in the measurement.
1f2eecd
to
33adc5b
Compare
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
==========================================
+ Coverage 82.69% 82.74% +0.05%
==========================================
Files 34 35 +1
Lines 3189 3181 -8
==========================================
- Hits 2637 2632 -5
+ Misses 408 406 -2
+ Partials 144 143 -1
Continue to review full report at Codecov.
|
33adc5b
to
6ef23fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Do we not have a unit test for executing the resume provider? https://codecov.io/gh/argoproj/argo-rollouts/pull/189/diff#D11-194 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add a test for missing coverage
29975f0
to
2a7092f
Compare