Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement job-based metric provider #186

Merged
merged 4 commits into from
Oct 8, 2019
Merged

Conversation

jessesuen
Copy link
Member

@jessesuen jessesuen commented Oct 5, 2019

This PR adds a job as a metric provider. Success is measured by exit code. If the job completes with exit code zero, then the metric is successful, otherwise it failed.

@codecov
Copy link

codecov bot commented Oct 6, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@b0a5487). Click here to learn what that means.
The diff coverage is 75.34%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #186   +/-   ##
=========================================
  Coverage          ?   82.33%           
=========================================
  Files             ?       34           
  Lines             ?     3182           
  Branches          ?        0           
=========================================
  Hits              ?     2620           
  Misses            ?      415           
  Partials          ?      147
Impacted Files Coverage Δ
service/service.go 58.57% <0%> (ø)
providers/job/job.go 100% <100%> (ø)
utils/analysis/analysis.go 97.67% <100%> (ø)
utils/controller/controller.go 94.2% <100%> (ø)
providers/prometheus/prometheus.go 100% <100%> (ø)
rollout/controller.go 61.42% <16.66%> (ø)
experiments/controller.go 65.04% <16.66%> (ø)
analysis/controller.go 50.64% <25%> (ø)
analysis/analysis.go 80.53% <65%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0a5487...e41f56e. Read the comment docs.

@jessesuen jessesuen force-pushed the job-metric branch 5 times, most recently from bd1954b to 53d426a Compare October 6, 2019 09:35
@jessesuen jessesuen requested a review from dthomson25 October 6, 2019 10:07
@jessesuen jessesuen marked this pull request as ready for review October 6, 2019 10:07
Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor requests

utils/analysis/analysis.go Show resolved Hide resolved
analysis/analysis.go Show resolved Hide resolved
@jessesuen jessesuen force-pushed the job-metric branch 2 times, most recently from 82a76b6 to 552d4db Compare October 7, 2019 20:42
@jessesuen jessesuen merged commit b62d3e5 into argoproj:master Oct 8, 2019
@jessesuen jessesuen deleted the job-metric branch October 8, 2019 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants