Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky unit test #1831

Merged
merged 1 commit into from
Feb 1, 2022
Merged

fix: flaky unit test #1831

merged 1 commit into from
Feb 1, 2022

Conversation

harikrongali
Copy link
Contributor

Signed-off-by: hari rongali [email protected]

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: hari rongali <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.4% 4.4% Duplication

@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #1831 (29e7844) into master (d3275e0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1831   +/-   ##
=======================================
  Coverage   82.30%   82.30%           
=======================================
  Files         116      116           
  Lines       16370    16370           
=======================================
  Hits        13474    13474           
  Misses       2217     2217           
  Partials      679      679           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3275e0...29e7844. Read the comment docs.

@alexmt alexmt merged commit 86dc378 into argoproj:master Feb 1, 2022
@perenesenko
Copy link
Member

@harikrongali
I already made the changes for that but in the scope of another issue
54a54d8

Just have to use timeutil.Now() instead of metav1.Now()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants