feat: Added delay button in the scaled down revision (#1355) #1804

schakrad · 2022-01-25T21:22:32Z

fix for #1355

Before the addition of button.

After the addition of button to show the scaleDownDelay in seconds

Signed-off-by: “schakradari” <“[email protected]”>

Checklist:

Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
I've signed my commits with DCO
I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
My builds are green. Try syncing with master if they are not.
My organization is added to USERS.md.

codecov · 2022-01-25T21:40:39Z

Codecov Report

Merging #1804 (9acb544) into master (56a94f4) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1804      +/-   ##
==========================================
+ Coverage   82.31%   82.36%   +0.05%     
==========================================
  Files         116      119       +3     
  Lines       16371    16872     +501     
==========================================
+ Hits        13475    13897     +422     
- Misses       2217     2284      +67     
- Partials      679      691      +12

Impacted Files	Coverage Δ
utils/replicaset/replicaset.go	`88.27% <0.00%> (-1.78%)`	⬇️
rollout/canary.go	`76.32% <0.00%> (-0.58%)`	⬇️
utils/replicaset/canary.go	`89.26% <0.00%> (-0.23%)`	⬇️
rollout/trafficrouting/alb/alb.go	`81.95% <0.00%> (-0.18%)`	⬇️
rollout/experiment.go	`84.13% <0.00%> (ø)`
utils/service/service.go	`100.00% <0.00%> (ø)`
metricproviders/graphite/graphite.go	`100.00% <0.00%> (ø)`
pkg/kubectl-argo-rollouts/info/info.go	`100.00% <0.00%> (ø)`
metricproviders/prometheus/prometheus.go	`100.00% <0.00%> (ø)`
pkg/kubectl-argo-rollouts/cmd/get/get.go	`72.00% <0.00%> (ø)`
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56a94f4...9acb544. Read the comment docs.

harikrongali · 2022-01-25T22:51:30Z

@schakrad can you cleanup the PR and have diff show only required changes

harikrongali · 2022-01-26T22:28:52Z

ui/package.json

@@ -60,7 +60,7 @@
        "sass": "^1.32.8",
        "ts-loader": "^8.0.17",
        "webpack-bundle-analyzer": "^4.4.0",
-        "webpack-cli": "^4.5.0",


is this change required?

harikrongali · 2022-01-26T22:29:18Z

ui/yarn.lock

@@ -2256,22 +2256,22 @@
    "@webassemblyjs/wast-parser" "1.9.0"
    "@xtuc/long" "4.2.2"

-"@webpack-cli/configtest@^1.0.3":


not sure if lock file needs to be committed. @alexmt is it fine to commit this file?

@harikrongali Lock file does need to be committed, but we should avoid bumping versions in any of these packages if possible. @schakrad I don't see any code changes that should require updating package versions, can you confirm?

Thanks, @rbreeze for confirmation. @schakrad please revert the package.json update

Sure Hari, I will check and revert back.

harikrongali · 2022-01-26T22:31:01Z

Please add before and after snapshots as a part of the PR description.

Please fix CI checks: DCO & build
For DCO, you can squash commits and sign off on the last one

rbreeze

Code changes look good, my only request is to avoid changing package versions

rbreeze · 2022-01-27T04:16:24Z

ui/package.json

@@ -60,7 +60,7 @@
        "sass": "^1.32.8",
        "ts-loader": "^8.0.17",
        "webpack-bundle-analyzer": "^4.4.0",
-        "webpack-cli": "^4.5.0",


rbreeze · 2022-01-27T04:18:30Z

ui/yarn.lock

@@ -2256,22 +2256,22 @@
    "@webassemblyjs/wast-parser" "1.9.0"
    "@xtuc/long" "4.2.2"

-"@webpack-cli/configtest@^1.0.3":


@harikrongali Lock file does need to be committed, but we should avoid bumping versions in any of these packages if possible. @schakrad I don't see any code changes that should require updating package versions, can you confirm?

sonarqubecloud · 2022-01-27T16:52:33Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

Signed-off-by: “schakradari” <[email protected]>

…to fix-1355

ui/src/app/components/Timer/timer.tsx

Signed-off-by: “schakradari” <[email protected]>

ui/src/app/components/pods/pods.tsx

Signed-off-by: “schakradari” <[email protected]>

…i library Signed-off-by: Alexander Matyushentsev <[email protected]>

fix: use consistent versions of typescript and classnames with argo-ui library

Signed-off-by: “schakradari” <[email protected]>

Signed-off-by: Alexander Matyushentsev <[email protected]>

sonarqubecloud · 2022-02-08T18:30:15Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
3.1% Duplication

alexmt · 2022-02-08T20:40:59Z

LGTM.

@rbreeze can you please take a look one more time?

rbreeze

Just one last comment, can we revert package.json and yarn.lock changes?

alexmt · 2022-02-08T21:27:37Z

@rbreeze changes in package.json are actually required. Apparently argo-ui/argo-cd/ui and argo-rollouts/ui were using different classnames versions. I temporary downgraded classnames to unblock this PR.

rbreeze · 2022-02-08T21:36:07Z

@alexmt Oh I see, thank you!

rbreeze

LGTM!

schakrad marked this pull request as ready for review January 26, 2022 20:15

harikrongali requested review from rbreeze and alexmt and removed request for rbreeze January 26, 2022 22:27

harikrongali reviewed Jan 26, 2022

View reviewed changes

rbreeze suggested changes Jan 27, 2022

View reviewed changes

schakrad force-pushed the fix-1355 branch 3 times, most recently from 6babcef to bd414b8 Compare January 27, 2022 18:23

schakrad added 16 commits January 27, 2022 13:29

feat: Added delay button in the scaled down revision

79e3277

Signed-off-by: “schakradari” <[email protected]>

feat: Restored the deleted files

2aa9d9c

Signed-off-by: “schakradari” <[email protected]>

feat: Removed the log stmnts and spaces

2206c8c

Signed-off-by: “schakradari” <[email protected]>

Rolled back changes in the yaml files to the initial state

7e9ecfd

Signed-off-by: “schakradari” <[email protected]>

Rolled back changes in rollout-smi-experiment-step.yaml

f371151

Signed-off-by: “schakradari” <[email protected]>

Rolled back changes in rollout.tsx

4bc80b5

Signed-off-by: “schakradari” <[email protected]>

rolled back changes in rollout.tsx

0026f53

Signed-off-by: “schakradari” <[email protected]>

rolled back changes in revision.tsx

2e8cdff

Signed-off-by: “schakradari” <[email protected]>

rolled back changes in revision.tsx

c65dc0b

Signed-off-by: “schakradari” <[email protected]>

rolled back changes in package.json

ee5ef25

Signed-off-by: “schakradari” <[email protected]>

rolled back changes in yarn.lock

12bdebe

Signed-off-by: “schakradari” <[email protected]>

yarn.lock file after running yarn install

04b6227

Signed-off-by: “schakradari” <[email protected]>

deleted the extra changes

a184a55

Signed-off-by: “schakradari” <[email protected]>

deleted extra changes

d77009d

Signed-off-by: “schakradari” <[email protected]>

deleted the extra spaces

a173449

Signed-off-by: “schakradari” <[email protected]>

retry DCO check

93cf5e8

Signed-off-by: “schakradari” <[email protected]>

schakrad force-pushed the fix-1355 branch from bd414b8 to 93cf5e8 Compare January 27, 2022 18:32

harikrongali approved these changes Jan 27, 2022

View reviewed changes

Merge branch 'master' of https://github.com/argoproj/argo-rollouts in…

473f156

…to fix-1355

alexmt requested changes Jan 31, 2022

View reviewed changes

ui/src/app/components/Timer/timer.tsx Outdated Show resolved Hide resolved

ui/src/app/components/Timer/timer.tsx Outdated Show resolved Hide resolved

schakrad added 4 commits February 2, 2022 11:11

Included Ticker and removed timer

e198493

Signed-off-by: “schakradari” <[email protected]>

Removed extra space in yarn.lock

14e9398

Signed-off-by: “schakradari” <[email protected]>

Removed unnecessary yarn.lock

b1ccd13

Signed-off-by: “schakradari” <[email protected]>

organized the imports

f99a5d8

Signed-off-by: “schakradari” <[email protected]>

alexmt requested changes Feb 2, 2022

View reviewed changes

ui/src/app/components/pods/pods.tsx Outdated Show resolved Hide resolved

schakrad and others added 6 commits February 3, 2022 13:50

Changed the button to InfoItem instead of ActionButton

b9ceaff

Signed-off-by: “schakradari” <[email protected]>

fix: use consistent versions of typescript and classnames with argo-u…

52a7025

…i library Signed-off-by: Alexander Matyushentsev <[email protected]>

Merge pull request #1 from alexmt/fix-1355

1071b70

fix: use consistent versions of typescript and classnames with argo-ui library

Used Duration component for displaying scaledown time in InfoItem

4bb0eaa

Signed-off-by: “schakradari” <[email protected]>

removed comments

2ed87ec

Signed-off-by: “schakradari” <[email protected]>

Revert react-router upgrade

9acb544

Signed-off-by: Alexander Matyushentsev <[email protected]>

alexmt approved these changes Feb 8, 2022

View reviewed changes

rbreeze suggested changes Feb 8, 2022

View reviewed changes

rbreeze approved these changes Feb 8, 2022

View reviewed changes

alexmt merged commit 459112b into argoproj:master Feb 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Added delay button in the scaled down revision (#1355) #1804

feat: Added delay button in the scaled down revision (#1355) #1804

schakrad commented Jan 25, 2022 •

edited

Loading

codecov bot commented Jan 25, 2022 •

edited

Loading

harikrongali commented Jan 25, 2022

harikrongali Jan 26, 2022

rbreeze Jan 27, 2022

harikrongali Jan 26, 2022

rbreeze Jan 27, 2022

harikrongali Jan 27, 2022

schakrad Jan 27, 2022

harikrongali commented Jan 26, 2022

rbreeze left a comment

rbreeze Jan 27, 2022

rbreeze Jan 27, 2022

sonarqubecloud bot commented Jan 27, 2022

sonarqubecloud bot commented Feb 8, 2022

alexmt commented Feb 8, 2022

rbreeze left a comment

alexmt commented Feb 8, 2022

rbreeze commented Feb 8, 2022

rbreeze left a comment

feat: Added delay button in the scaled down revision (#1355) #1804

feat: Added delay button in the scaled down revision (#1355) #1804

Conversation

schakrad commented Jan 25, 2022 • edited Loading

codecov bot commented Jan 25, 2022 • edited Loading

Codecov Report

harikrongali commented Jan 25, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

harikrongali commented Jan 26, 2022

rbreeze left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 27, 2022

sonarqubecloud bot commented Feb 8, 2022

alexmt commented Feb 8, 2022

rbreeze left a comment

Choose a reason for hiding this comment

alexmt commented Feb 8, 2022

rbreeze commented Feb 8, 2022

rbreeze left a comment

Choose a reason for hiding this comment

schakrad commented Jan 25, 2022 •

edited

Loading

codecov bot commented Jan 25, 2022 •

edited

Loading