fix: canary replicas/weight could flap during abort with dynamic scaling #1794

jessesuen · 2022-01-20T20:56:54Z

Resolves #1665
Resolves #1701

When using dynamicStableScaling, and the rollout was aborted, we would incorrectly increase the weight of the canary if the available stable replicas was flapping. This fix ensures that when we are aborting, we are only ever decreasing the weight and never increasing this.

While testing this fix, I also discovered that a portion of the traffic routing unit tests was not functioning properly because the expected mock functions were not executed properly (Issue #1701)

Signed-off-by: Jesse Suen [email protected]

codecov · 2022-01-20T21:06:37Z

Codecov Report

Merging #1794 (4f2f027) into master (a74ad8e) will increase coverage by 0.20%.
The diff coverage is 88.46%.

@@            Coverage Diff             @@
##           master    #1794      +/-   ##
==========================================
+ Coverage   82.07%   82.28%   +0.20%     
==========================================
  Files         116      116              
  Lines       16349    16366      +17     
==========================================
+ Hits        13419    13466      +47     
+ Misses       2243     2220      -23     
+ Partials      687      680       -7

Impacted Files	Coverage Δ
utils/conditions/conditions.go	`80.76% <ø> (ø)`
rollout/trafficrouting.go	`80.45% <85.00%> (+9.37%)`	⬆️
rollout/restart.go	`98.69% <100.00%> (+0.04%)`	⬆️
rollout/trafficrouting/smi/smi.go	`94.82% <100.00%> (-0.09%)`	⬇️
rollout/controller.go	`75.38% <0.00%> (+0.57%)`	⬆️
rollout/replicaset.go	`69.44% <0.00%> (+1.85%)`	⬆️
rollout/canary.go	`76.90% <0.00%> (+1.97%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a74ad8e...4f2f027. Read the comment docs.