Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Show container images in dashboard for rollouts with a WorkloadRef #1792

Merged
merged 3 commits into from
Jan 20, 2022

Conversation

rbreeze
Copy link
Member

@rbreeze rbreeze commented Jan 20, 2022

Fixes #1525

Signed-off-by: Remington Breeze [email protected]

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

}



Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove extract space

pkg/kubectl-argo-rollouts/info/rollout_info.go Outdated Show resolved Hide resolved
Signed-off-by: Remington Breeze <[email protected]>
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #1792 (cf80244) into master (f5c229b) will decrease coverage by 0.05%.
The diff coverage is 52.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1792      +/-   ##
==========================================
- Coverage   82.11%   82.05%   -0.06%     
==========================================
  Files         116      116              
  Lines       16317    16330      +13     
==========================================
+ Hits        13398    13400       +2     
- Misses       2236     2243       +7     
- Partials      683      687       +4     
Impacted Files Coverage Δ
...ctl-argo-rollouts/viewcontroller/viewcontroller.go 70.00% <37.50%> (-2.03%) ⬇️
pkg/kubectl-argo-rollouts/info/rollout_info.go 87.50% <66.66%> (-1.27%) ⬇️
rollout/trafficrouting/istio/controller.go 50.81% <0.00%> (-1.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5c229b...cf80244. Read the comment docs.

Signed-off-by: Remington Breeze <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.1% 5.1% Duplication

Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jessesuen jessesuen merged commit 86055ee into argoproj:master Jan 20, 2022
@rbreeze rbreeze deleted the workload-ref-dashboard branch January 21, 2022 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollouts Dashboard doesn't fully support using workloadRef
3 participants