Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retry Experiment ReplicaSet scaling conflict errors #1778

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

jessesuen
Copy link
Member

Conflict errors when scaling Experiment ReplicaSets could cause the Experiment to fail. This should cause it to re-reconcile/retry.

Resolves #1775

Signed-off-by: Jesse Suen [email protected]

@jessesuen jessesuen force-pushed the fix-handle-exp-conflict-err branch from 417b390 to c974df4 Compare January 15, 2022 09:53
@sonarcloud
Copy link

sonarcloud bot commented Jan 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #1778 (c974df4) into master (f419820) will increase coverage by 0.02%.
The diff coverage is 93.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1778      +/-   ##
==========================================
+ Coverage   82.03%   82.05%   +0.02%     
==========================================
  Files         116      116              
  Lines       16175    16216      +41     
==========================================
+ Hits        13269    13306      +37     
- Misses       2227     2230       +3     
- Partials      679      680       +1     
Impacted Files Coverage Δ
utils/replicaset/canary.go 89.49% <92.45%> (+0.07%) ⬆️
experiments/replicaset.go 85.25% <100.00%> (+0.27%) ⬆️
pkg/apis/rollouts/validation/validation.go 93.96% <100.00%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f93f9b...c974df4. Read the comment docs.

Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessesuen jessesuen merged commit b0ae59a into argoproj:master Jan 19, 2022
@jessesuen jessesuen deleted the fix-handle-exp-conflict-err branch January 19, 2022 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operation cannot be fulfilled on replicasets.apps: the object has been modified
2 participants