chore: make ci/local codegen consistent #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessesuen
force-pushed
the
fix-codegen
branch
from
4a0febd to
eda748c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1772 +/- ##
=======================================
Coverage 82.03% 82.03%
=======================================
Files 116 116
Lines 16171 16171
=======================================
Hits 13266 13266
Misses 2226 2226
Partials 679 679
Continue to review full report at Codecov.
|
Signed-off-by: Jesse Suen <[email protected]>
jessesuen
force-pushed
the
fix-codegen
branch
from
eda748c to
a76c9f4
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI system is not currently catching PRs which fail to run
make codegen. Also, the local vs. CI codegen was inconsistent with each other and not reproducible.This PR creates a consistent toolchain for CI vs. local by running:
It should not be necessary to install anything using
brewanymore, includingbrew install protobufSigned-off-by: Jesse Suen [email protected]