Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix doc for valueFrom fields for analysis args #1763

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

harikrongali
Copy link
Contributor

Fixes comment #1629 (comment)
Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@harikrongali harikrongali changed the title Fix doc for valueFrom fields for analysis args doc: Fix doc for valueFrom fields for analysis args Jan 12, 2022
@harikrongali harikrongali changed the title doc: Fix doc for valueFrom fields for analysis args doc: fix doc for valueFrom fields for analysis args Jan 12, 2022
@harikrongali harikrongali force-pushed the patch-1 branch 3 times, most recently from a37feec to bf3b7cc Compare January 12, 2022 20:58
@harikrongali harikrongali changed the title doc: fix doc for valueFrom fields for analysis args docs: fix doc for valueFrom fields for analysis args Jan 12, 2022
@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #1763 (7568d67) into master (4739bcd) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 7568d67 differs from pull request most recent head dd79dee. Consider uploading reports for the commit dd79dee to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1763      +/-   ##
==========================================
- Coverage   82.03%   82.03%   -0.01%     
==========================================
  Files         116      116              
  Lines       16171    16175       +4     
==========================================
+ Hits        13266    13269       +3     
- Misses       2226     2227       +1     
  Partials      679      679              
Impacted Files Coverage Δ
rollout/trafficrouting/alb/alb.go 82.12% <0.00%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4739bcd...dd79dee. Read the comment docs.

docs/features/analysis.md Outdated Show resolved Hide resolved
docs/features/analysis.md Outdated Show resolved Hide resolved
@harikrongali harikrongali force-pushed the patch-1 branch 3 times, most recently from 7568d67 to 9d7c07d Compare January 14, 2022 20:54
Signed-off-by: hari rongali <[email protected]>

doc: update example to refer canary target groups

Signed-off-by: hari rongali <[email protected]>

doc: cleanup example

Signed-off-by: hari rongali <[email protected]>

doc: add clarification for rollout status

Signed-off-by: hari rongali <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jan 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.7% 4.7% Duplication

@jessesuen jessesuen merged commit a051f38 into argoproj:master Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants