Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Remove duplicate sentence #1756

Merged
merged 1 commit into from
Jan 11, 2022
Merged

docs: Remove duplicate sentence #1756

merged 1 commit into from
Jan 11, 2022

Conversation

mubarak-j
Copy link
Contributor

@mubarak-j mubarak-j commented Jan 10, 2022 •
edited
Loading

This removes a duplicate sentence in dry-run docs

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@mubarak-j mubarak-j force-pushed the patch-DryRun-docs branch 2 times, most recently from 5f1c4b0 to 32156ad Compare January 10, 2022 19:16
@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jessesuen jessesuen merged commit e2201d0 into argoproj:master Jan 11, 2022
Eslam-mohammed-anwar pushed a commit to Eslam-mohammed-anwar/argo-rollouts that referenced this pull request Jan 12, 2022
@mubarak-j @Eslam-mohammed-anwar
docs(controller): remove duplicate sentence. (argoproj#1756)
92abaf0 
Signed-off-by: Mubarak Jama <[email protected]>
Signed-off-by: Eslam Mohammed <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessesuen jessesuen jessesuen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mubarak-j @jessesuen