Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add notiication templates for rollouts and analysis #1753

Merged
merged 2 commits into from
Jan 12, 2022

Conversation

RaviHari
Copy link
Contributor

@RaviHari RaviHari commented Jan 8, 2022

Signed-off-by: Ravi Hari [email protected]
Fixes: #1694
Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@codecov
Copy link

codecov bot commented Jan 8, 2022

Codecov Report

Merging #1753 (e4fe8d9) into master (c291d2d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1753   +/-   ##
=======================================
  Coverage   82.02%   82.02%           
=======================================
  Files         116      116           
  Lines       16096    16096           
=======================================
  Hits        13203    13203           
  Misses       2218     2218           
  Partials      675      675           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c291d2d...e4fe8d9. Read the comment docs.

@harikrongali
Copy link
Contributor

@RaviHari can you generate manifest (make manifest should update manifest files)? https://github.com/argoproj/argo-rollouts/blob/master/manifests/notifications-install.yaml should get updated with new configs

@sonarcloud
Copy link

sonarcloud bot commented Jan 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.3% 5.3% Duplication

@alexmt alexmt merged commit b833073 into argoproj:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Notifications for Analysis Runs
3 participants