fix: missing array type in the CRD rollout's spec volumes

[huikang]

Signed-off-by: Hui Kang [email protected]

fix #1721

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
• The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
• I've signed my commits with DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My builds are green. Try syncing with master if they are not.
• My organization is added to USERS.md.

[codecov]

Codecov Report

Merging #1737 (4984772) into master (04494ef) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1737   +/-   ##
=======================================
  Coverage   82.02%   82.02%           
=======================================
  Files         116      116           
  Lines       16096    16096           
=======================================
  Hits        13203    13203           
  Misses       2218     2218           
  Partials      675      675           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04494ef...4984772. Read the comment docs.

[jessesuen]

@huikang thanks for fixing this. Do you think we could modify an e2e test to have a volume so that we catch this in the future?

[huikang]

@huikang thanks for fixing this. Do you think we could modify an e2e test to have a volume so that we catch this in the future?

Sure, let me look into this and get back to you later.

[huikang]

@jessesuen , checking that the volumes field is an array seems a feature starting from k8s release 1.23.1 (which could put more strict check on the crd fields).

For k8s version v1.21.1, v1.22.1, the original install.yaml works fine, although it misses the array type for the volumes.
Only k8s v1.23.1 reports the following error with the wrong rollout crd:

"The Rollout \"rollouts-demo\" is invalid: spec.template.spec.volumes[0].name: Required value"
  namespace=default rollout=rollouts-demo

Since the existing git CI of this repo defaults to v1.22.1, one solution would be to upgrade the version to v1.23.1

argo-rollouts/.github/workflows/e2e.yaml

Lines 25 to 32 in c291d2d

	- name: Setup k3s
	run: |
	curl -sfL https://get.k3s.io | sh -
	sudo mkdir ~/.kube
	sudo cp /etc/rancher/k3s/k3s.yaml ~/.kube/config
	sudo chmod 755 ~/.kube/config
	kubectl version
	kubectl create ns argo-rollouts

and then add volumes to one of the existing e2e rollout.

What do you think?

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[jessesuen]

We can add e2e test as a separate PR which conditionally skips depending on the k8s version it is running against.