Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin): Fixes arm64 compatibility to plugin docker image. Fixes #1728 #1732

Merged
merged 9 commits into from
Jan 4, 2022

Conversation

cguertin14
Copy link
Contributor

@cguertin14 cguertin14 commented Dec 28, 2021

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

What's accomplished

The quay.io/argoproj/kubectl-argo-rollouts can now run on arm64 :D.
Closes #1728, which contains all the important details about this.

Demo of the new fix

Wrote a quick demo using the new docker image which I pushed to my own Quay account for testing. We can see in the screenshot that the new Docker image runs smoothly on arm64 and the old one does not.

image

@cguertin14 cguertin14 force-pushed the feature/kubectl-plugin-arm64 branch from 2aef6ee to 028bd3e Compare December 28, 2021 16:23
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #1732 (028bd3e) into master (a3477cf) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1732      +/-   ##
==========================================
+ Coverage   82.02%   82.04%   +0.01%     
==========================================
  Files         116      116              
  Lines       16096    16096              
==========================================
+ Hits        13203    13206       +3     
+ Misses       2218     2216       -2     
+ Partials      675      674       -1     
Impacted Files Coverage Δ
rollout/trafficrouting/istio/controller.go 52.43% <0.00%> (+1.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3477cf...028bd3e. Read the comment docs.

Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@jessesuen jessesuen merged commit 0bc0592 into argoproj:master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubectl-argo-rollouts arm64 docker image not working - Dashboard
2 participants