-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin): Fixes arm64 compatibility to plugin docker image. Fixes #1728 #1732
fix(plugin): Fixes arm64 compatibility to plugin docker image. Fixes #1728 #1732
Conversation
Signed-off-by: Charles Guertin <[email protected]>
Signed-off-by: Charles Guertin <[email protected]>
Signed-off-by: Charles Guertin <[email protected]>
Signed-off-by: Charles Guertin <[email protected]>
Signed-off-by: Charles Guertin <[email protected]>
Signed-off-by: Charles Guertin <[email protected]>
Signed-off-by: Charles Guertin <[email protected]>
Signed-off-by: Charles Guertin <[email protected]>
Signed-off-by: Charles Guertin <[email protected]>
2aef6ee
to
028bd3e
Compare
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## master #1732 +/- ##
==========================================
+ Coverage 82.02% 82.04% +0.01%
==========================================
Files 116 116
Lines 16096 16096
==========================================
+ Hits 13203 13206 +3
+ Misses 2218 2216 -2
+ Partials 675 674 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.What's accomplished
The
quay.io/argoproj/kubectl-argo-rollouts
can now run on arm64 :D.Closes #1728, which contains all the important details about this.
Demo of the new fix
Wrote a quick demo using the new docker image which I pushed to my own Quay account for testing. We can see in the screenshot that the new Docker image runs smoothly on arm64 and the old one does not.