Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify the setCanaryScale of Dynamic Canary Scale #1703

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

huikang
Copy link
Member

@huikang huikang commented Dec 13, 2021

Signed-off-by: Hui Kang [email protected]

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@huikang huikang requested a review from jessesuen December 13, 2021 05:59
@huikang huikang force-pushed the doc-clarify-canary-scale branch from d3a3e86 to 37970ea Compare December 13, 2021 06:00
@huikang huikang changed the title doc: clarify the setCanaryScale of Dynamic Canary Scale docs: clarify the setCanaryScale of Dynamic Canary Scale Dec 13, 2021
@huikang huikang force-pushed the doc-clarify-canary-scale branch from 37970ea to db6b234 Compare December 13, 2021 18:11
@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #1703 (db6b234) into master (b3d50d1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1703   +/-   ##
=======================================
  Coverage   82.06%   82.06%           
=======================================
  Files         116      116           
  Lines       16075    16075           
=======================================
  Hits        13192    13192           
  Misses       2210     2210           
  Partials      673      673           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3d50d1...db6b234. Read the comment docs.

@jessesuen jessesuen merged commit d1eef41 into argoproj:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants