fix: missing rollout informer writeback #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesse Suen <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #1698 +/- ##
==========================================
- Coverage 82.08% 82.06% -0.02%
==========================================
Files 116 116
Lines 16073 16075 +2
==========================================
- Hits 13193 13192 -1
- Misses 2208 2210 +2
- Partials 672 673 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #913
I finally encountered the e2e flakiness #913 in local development and spent some time studying the sequence of events and logs. I believe the root cause to be a bug in the controller with the informer cache becoming stale, because we don't write back the rollout in the event where
spec.replicasis defaulted.Update: this will only fix one source of e2e flakiness, but there is much more to be done
Signed-off-by: Jesse Suen [email protected]